Allow PrettyPrintWriter to replace invalid XML characters when not running in quirks mode
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…running in quirks mode
|
This is actually a good idea! |
joehni
pushed a commit
that referenced
this pull request
Sep 27, 2023
…running in quirks mode. Closes #335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From jenkinsci/jenkins#7875:
This PR offers an alternative to quirks mode ("replacement mode") for XML 1.0 and XML 1.1 serialization that replaces invalid characters with the U+FFFD � replacement character, thus ensuring that the XML written out by
PrettyPrintWriteris always valid XML 1.0 or XML 1.1 without forcing consumers to sanitize their input.