Skip to content

Commit

Permalink
chore: some minor changes
Browse files Browse the repository at this point in the history
  • Loading branch information
pplmx committed Aug 13, 2024
1 parent 2614ae8 commit e5bd0ee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
9 changes: 0 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,5 @@ Try to use a clear title, and describe your problem with complete sentences.

Try to do one pull request per change.

## GitHub Actions

When we have to mix GitHub actions variables with the `{{ }}` liquid syntax,
GitHub actions variable are written in the format
`{{ "{{ github.variable " }}}}` instead of `{{ github.variable }}`.

Of course, when doing `cargo generate` the ugly version is replaced with the
expected one.

See [Continuous delivery](https://github.com/x-pt/template/blob/main/.github/workflows/cd.yml)
as an example.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
uses: docker/login-action@v3
with:
registry: ghcr.io
username: {{ "${{ github.repository_owner " }}}}
password: {{ "${{ secrets.GITHUB_TOKEN " }}}}
username: {{ "${{ github.repository_owner }}" }}
password: {{ "${{ secrets.GITHUB_TOKEN }}" }}
-
name: Build and Export to Docker
uses: docker/build-push-action@v6
Expand Down

0 comments on commit e5bd0ee

Please sign in to comment.