-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search to formula #21
Add search to formula #21
Conversation
Reviewing now. Will provide a design PR with some of my suggestions shortly. |
Hey, @flash1293. Per my previous comment, I've made a quick design PR for this branch to tweak some of the styles. Please review here when you get a moment: flash1293#13 Additionally, a few questions came up during my review of this PR:
|
[Lens] Custom Formula Docs Search Design Update
@MichaelMarcialis Made the section headers searchable as well (including hiding them if nothing in a section matches current search) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flash1293 LGTM, just curious about the markdown switch.
} from '@elastic/eui'; | ||
import { Markdown } from '../../../../../../../../../src/plugins/kibana_react/public'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we agreed on EuiMarkdownFormat @flash1293?
The |
Adds a search input to the formula help