Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes + lint #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes + lint #12

wants to merge 3 commits into from

Conversation

yunginnanet
Copy link

  • use proper shebang for portability
  • tempfile is deprecated, use mktemp
  • compare output of command directly
  • read with -r to prevent mangling
  • concatenate properly with * instead of @
  • escape quote the eval line (this tool didn't work for me without this)
  • double quote all variables where appropriate

@yunginnanet
Copy link
Author

merged #11 since idk if this will ever get merged to origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunginnanet @BrandonWill