airframe-sql: Fix column aliasing in CTEResolver #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
commented
Feb 9, 2023
| val resolvedPlan = | ||
| SQLAnalyzer.analyze("with t1 (xid) as (select id as pid from A) select xid from t1", "default", demoCatalog) | ||
| val sql = SQLGenerator.print(resolvedPlan).toLowerCase | ||
| sql shouldBe "with t1 as (select id as xid from (select id as pid from a)) select xid from t1" |
There was a problem hiding this comment.
Without this fix, the following SQL (id as pid as xid isn invalid) is generated:
with t1 as (select id as pid as xid from (select id as pid from a)) select xid from t1
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2741 +/- ##
=======================================
Coverage 82.20% 82.21%
=======================================
Files 337 337
Lines 14124 14125 +1
Branches 2242 2262 +20
=======================================
+ Hits 11611 11613 +2
+ Misses 2513 2512 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.