Skip to content

Commit

Permalink
Reland "[cpu-profiler] Turn on detailed line info for optimized code"
Browse files Browse the repository at this point in the history
This is a reland of 898f880

Original change's description:
> [cpu-profiler] Turn on detailed line info for optimized code
> 
> Cautiously turn on this flag by default to check the impact on
> performance bots. Could show minor regressions in old space and/or
> code_and_metadata memory buckets.
> 
> Bug: v8:7983
> Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd
> Reviewed-on: https://chromium-review.googlesource.com/1162234
> Commit-Queue: Yang Guo <[email protected]>
> Reviewed-by: Yang Guo <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#54908}

Bug: v8:7983
Change-Id: Iff53bc19c92f26f386948bd4a58e8dcf0493cf0d
Reviewed-on: https://chromium-review.googlesource.com/1177481
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Peter Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#55156}
  • Loading branch information
psmarshall authored and Commit Bot committed Aug 16, 2018
1 parent 0c85d81 commit 84894ce
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/flag-definitions.h
Original file line number Diff line number Diff line change
Expand Up @@ -1257,9 +1257,8 @@ DEFINE_BOOL(log_function_events, false,
DEFINE_BOOL(prof, false,
"Log statistical profiling information (implies --log-code).")

DEFINE_BOOL(detailed_line_info, false,
DEFINE_BOOL(detailed_line_info, true,
"Always generate detailed line information for CPU profiling.")
DEFINE_IMPLICATION(future, detailed_line_info)

#if defined(ANDROID)
// Phones and tablets have processors that are much slower than desktop
Expand Down

0 comments on commit 84894ce

Please sign in to comment.