Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Sidebar Clickability Issue for Non-Interactive Elements #714

Closed
wants to merge 0 commits into from

Conversation

gorsyan
Copy link
Contributor

@gorsyan gorsyan commented Dec 24, 2023

Fixed Bug #712 Corrected an Issue Where the Sidebar Element Remained Clickable Despite Being Intended as Non-Interactive, Leading to User Data Loss. Implemented Explicit CSS Restrictions to Disable Pointer Events on Elements with the 'Disabled' Attribute. Additionally, Added a Check to Ensure Event Listeners in the Sidebar Element are Inactive if the Array of Selected Items is Zero, Preventing Unintended Interactions.

@ghost
Copy link

ghost commented Dec 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@yannickwurm
Copy link
Member

yannickwurm commented Jan 19, 2024

Hiya @gorsyan - I'm sorry - I'm pretty sure that this may now need to be rebased given that there have been minor changes to what contributes to the .min.js

Copy link

codeclimate bot commented Jan 23, 2024

Code Climate has analyzed commit a67bfdd and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 81.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants