-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken astvalidation if type requires [NotNull!] and [NotNull!] or [NotNull!]! was provided #1096
Comments
@devsergiy thanks! |
devsergiy
pushed a commit
that referenced
this issue
Mar 3, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.161](v2.0.0-rc.160...v2.0.0-rc.161) (2025-02-28) ### Bug Fixes * fix validation of variables used in nested fields of type list of an input object ([#1099](#1099)) ([d74dc37](d74dc37)), closes [#1096](#1096) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@devsergiy hi! in PR #1082 you broken the opposite
this test now fails:
(
[String!]
arg and[String!]
type)Also more restrictive
[String!]!
in args will fail too.Before this PR everything was fine (albeit wo test)
Originally posted by @mocksoul in #1082 (comment)
all variants after PR #1082
after with PR
(actual in arg => in type definition)
OK [string!]! => [string]
!! FAIL [string!]! => [string]!
!! FAIL [string!]! => [string!]
OK [string!]! => [string!]!
OK [string!] => [string!]!
FAIL [string!] => [string]! (kinda expected)
!! FAIL [string!] => [string!]
FAIL [string!] => [string!]! (kinda expected)
OK [string]! => [string]
OK [string]! => [string]!
FAIL [string]! => [string!] (kinda expected)
FAIL [string]! => [string!]! (kinda expected)
OK [string] => [string]
FAIL [string] => [string]! (kinda expected)
FAIL [string] => [string!] (kinda expected)
FAIL [string] => [string!]! (kinda expected)
The text was updated successfully, but these errors were encountered: