Add an Authoriser interface and use it to add mocks for testing #98
+562
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this may be failing because of a bug in go-irodsclient; a first run of the tests fails, while subsequent runs on the same iRODS succeed and the incorrect values seem to be coming up from the go-irodsclient API. |
kjsanger
force-pushed
the
feature/mocks-and-tests
branch
from
7aef239 to
3beb2f1
Compare
This wasn't the issue, although there is a bug in go-irodsclient because it reports a group as being a member of itself. |
kjsanger
force-pushed
the
feature/mocks-and-tests
branch
2 times, most recently
from
f7c5d5e to
0f5141d
Compare
The Authoriser interface implements a small subset of the go-irodsclient API sufficient to create mocks to emulate having users and groups from federated zones. go-irodsclient doesn't have full federation support, but nevertheless federated users are detected and reported by its API. The aim is to allow some level of testing against them without requiring a real federated iRODS servers. This commit also includes some refactoring to reduce the number of parameters used by some functions, particularly where user/group names and zones are being passed seperately, but are actually related.
kjsanger
force-pushed
the
feature/mocks-and-tests
branch
from
0f5141d to
f3a61f3
Compare
Co-authored-by: dkj <[email protected]>
Co-authored-by: dkj <[email protected]>
Co-authored-by: dkj <[email protected]>
Co-authored-by: dkj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Authoriser interface implements a small subset of the go-irodsclient API sufficient to create mocks to emulate having users and groups from federated zones.
go-irodsclient doesn't have full federation support, but nevertheless federated users are detected and reported by its API. The aim is to allow some level of testing against them without requiring a real federated iRODS servers.
This commit also includes some refactoring to reduce the number of parameters used by some functions, particularly where user/group names and zones are being passed seperately, but are actually related.