-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct level populations for ionization and recombination processes #223
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 91.67% 91.26% -0.42%
==========================================
Files 23 23
Lines 1947 2015 +68
==========================================
+ Hits 1785 1839 +54
- Misses 162 176 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Based on the test failures, it looks like the free-free and free-bound values have changed, likely due to the differences in how I'm interpolating the ioneq. The differences are surprisingly large which is worrying. |
I've finally settled on using |
Fixes #24
This PR accomplishes two main things:
cilvl
andreclvl
files as described in Landi et al. (2006)A few remaining TODOs: