Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Add typescript typings #38

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

ablok
Copy link
Contributor

@ablok ablok commented Oct 27, 2022

Wanted to try out this library, saw it was missing type info.
Had to upgrade eslint parser to get rid of errors in the typings file. That caused package-lock file to change substantially because I am using a recent NPM version.

@ablok
Copy link
Contributor Author

ablok commented Oct 28, 2022

Failure seems to be caused by this:
WordPress/gutenberg#17324
I think you might need to change the workflow and add the pull_request_target trigger.

@wswebcreation wswebcreation merged commit 72dcd8d into wswebcreation:main Oct 30, 2022
@wswebcreation
Copy link
Owner

Thanks for your work @ablok

@wswebcreation
Copy link
Owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants