Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accelerator 4] Adding DCR gateway implementation #229

Merged
merged 14 commits into from
Jan 24, 2025
Merged

[Accelerator 4] Adding DCR gateway implementation #229

merged 14 commits into from
Jan 24, 2025

Conversation

Ashi1993
Copy link
Contributor

@Ashi1993 Ashi1993 commented Dec 12, 2024 •
edited by Akila94
Loading

[Accelerator 4] Adding DCR gateway implementation

This PR adds DCR gateway implementation

Issue link: required

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

@Ashi1993 Ashi1993 marked this pull request as draft December 19, 2024 08:13
@Ashi1993 Ashi1993 marked this pull request as ready for review January 17, 2025 05:04
Akila94
Akila94 reviewed Jan 22, 2025
View reviewed changes
...main/java/org/wso2/financial/services/accelerator/gateway/executor/impl/dcr/DCRExecutor.java Outdated
Comment on lines 118 to 123
} catch (BadJOSEException e) {
log.error("Error occurred while validating the signature", e);
handleBadRequestError(fsapiRequestContext, "Invalid request signature. " + e.getMessage());
} catch (JOSEException | MalformedURLException e) {
log.error("Error occurred while validating the signature", e);
handleBadRequestError(fsapiRequestContext, "Invalid request signature");
Copy link
Member

@Akila94 Akila94 Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we combine these two catch blocks since they handle the same error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, from where can the MalformedURLException can be thrown and how it relates to signature validation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed,
MalformedURLException is thrown when there is an issue with the JWKS URI

@anjuchamantha anjuchamantha merged commit 6a2926f into wso2:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imesh94 imesh94 imesh94 approved these changes

@Akila94 Akila94 Akila94 approved these changes

@anjuchamantha anjuchamantha anjuchamantha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashi1993 @imesh94 @Akila94 @anjuchamantha