Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPoP Authorization Code Binding For PAR Requests #14

Merged
merged 4 commits into from
May 10, 2024

Conversation

PasinduLakshan99
Copy link
Contributor

Purpose

This PR extends the functionality of DPoPEventHandler class to handle events of type PRE_HANDLE_PAR_REQUEST.

Approach

If a DPoP headers is present in a PAR request, DPoPEventHandler will validate the header and if the validation failed,the request will be rejected. Uppon successful validation, the event handler will check for the presence of dpop_jkt request parameter in the PAR request.

  • If dpop_jkt request parameter is also present in the PAR request, the JWK thumbprint of the DPoP header will be compared with value of that parameter and if the comparison failed, the request will be rejected.
  • Alternatively, if the dpop_jkt request parameter is absent in the request, the thumbprint value derived from the validated DPoP proof header will be appended to the request parameter set with the key dpop_jkt. This addition ensures the continuation of the authorization code binding mechanism as if the dpop_jkt parameter had been initially included in the request.

Copy link
Contributor

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thumimku Thumimku merged commit edc21b2 into wso2-extensions:main May 10, 2024
3 checks passed
@PasinduLakshan99 PasinduLakshan99 deleted the parAuthzCodeBinding branch May 16, 2024 07:46
Thumimku pushed a commit to Thumimku/identity-oauth-dpop that referenced this pull request Nov 27, 2024
Thumimku pushed a commit to Thumimku/identity-oauth-dpop that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants