KMyMoney AppImage build fixes for new ports. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty string will be considered as NOTFOUND by cmake and fail the build. Therefore we use a non-empty string when a glibc implementation has been detected.
Passing an empty string as LibIntl_LIBRARIES has the side effect that cmake will try to link against an empty library '-l " "'.
wrobelda
pushed a commit
that referenced
this pull request
Aug 15, 2022
* [openlap] Add new port Merge pull request #1 from dg0yt/openldap Signed-off-by: Gordon Smith <[email protected]> * [openlap] Add new port m4.patch is needed when libtool < 2.4.6 m4.patch will only work with autoconf < 2.70 Signed-off-by: Gordon Smith <[email protected]> * wip: Make cyrus-sasl optional Signed-off-by: Gordon Smith <[email protected]>
|
Alex, are you planning on resuming that work at some point? For what it's worth, by a glance, a lot of these patches were already merged upstream to vcpkg. |
|
Hey Dawid,
sorry for the late answer. I wanted to continue this for a long time already, but currently I’m super busy with life, at least until end of November.
Hopefully I will be able to continue this in December and finalise it, now that many patches have been merged upstream already.
All the Best
Alex
… On 19 Aug 2022, at 12:50, Dawid Wróbel ***@***.***> wrote:
Alex, are you planning on resuming that work at some point? For what it's worth, by a glance, a lot of these patches were already merged upstream to vcpkg.
—
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGEG33FYJDZAFQURFD6KFULVZ5RINANCNFSM4YEM56RQ>.
You are receiving this because you authored the thread.
|
|
Thanks for the update. All is totally understandable! I'll keep you posted if we ourselves make any progress in this domain. PS. Are you on Telegram? Feel free to drop by our channel, would be easier to stay in touch like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes I have to do to fix the KMyMoney AppImage build.
Don't merge yet, as it still does not build. I will have to fix more issues and will add them to this PR.