feat(Testing): Ensure that CreateRequest return request with correct …

…url and json accept header
wrk-flow · Nov 16, 2022 · a9d1a29 · a9d1a29
1 parent 0ddce86
commit a9d1a29
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 6 deletions.
diff --git a/phpunit.xml b/phpunit.xml
@@ -29,5 +29,6 @@
     <php>
         <env name="DB_CONNECTION" value="testing"/>
         <env name="APP_KEY" value="base64:2fl+Ktvkfl+Fuz4Qp/A75G2RTiWVA/ZoKZvp6fiiM10="/>
+        <env name="APP_URL" value="https://testing" />
     </php>
 </phpunit>
diff --git a/src/Testing/Concerns/CreateRequest.php b/src/Testing/Concerns/CreateRequest.php
@@ -6,6 +6,8 @@
 
 use Illuminate\Foundation\Application;
 use Illuminate\Http\Request;
+use Illuminate\Routing\UrlGenerator;
+use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
 
 trait CreateRequest
 {
@@ -16,10 +18,28 @@ trait CreateRequest
      *
      * @return TRequest
      */
-    public function createPostRequest(Application $application, string $requestClass, array $data): object
-    {
-        $request = new Request(request: $data);
-        $request->setMethod('POST');
+    public function createPostRequest(
+        Application $application,
+        string $requestClass,
+        array $data,
+        string $accept = 'application/json'
+    ): object {
+        /** @var UrlGenerator $urlGenerator */
+        $urlGenerator = $application->make(UrlGenerator::class);
+
+        $uri = $urlGenerator->to('');
+        $symfonyRequest = SymfonyRequest::create(
+            uri: $uri,
+            method: 'POST',
+            parameters: $data,
+            cookies: [],
+            files: [],
+            server: [
+                'HTTP_ACCEPT' => $accept,
+            ],
+        );
+
+        $request = Request::createFromBase($symfonyRequest);
 
         $application->instance('request', $request);
 

diff --git a/tests/Feature/Config/Laravel/AppConfigTest.php b/tests/Feature/Config/Laravel/AppConfigTest.php
@@ -68,7 +68,7 @@ public function testName(): void
     public function testGetUrl(): void
     {
         $this->assertConfigValue(
-            expectedDefaultValue: 'http://localhost',
+            expectedDefaultValue: 'https://testing',
             keys: [AppConfig::KeyUrl],
             overridesExpectationMap: [
                 'https://localhost' => 'https://localhost',

diff --git a/...esting/Concerns/CreatePostRequestTest.php → ...re/Testing/Concerns/CreateRequestTest.php b/...esting/Concerns/CreatePostRequestTest.php → ...re/Testing/Concerns/CreateRequestTest.php
@@ -7,7 +7,7 @@
 use LaraStrict\Testing\Concerns\CreateRequest;
 use Tests\LaraStrict\Feature\TestCase;
 
-class CreatePostRequestTest extends TestCase
+class CreateRequestTest extends TestCase
 {
     use CreateRequest;
 
@@ -18,6 +18,8 @@ public function testSuccess(): void
         ];
         $request = $this->createPostRequest($this->app(), requestClass: TestRequest::class, data: $data);
         $this->assertEquals($data, $request->validated());
+        $this->assertTrue($request->acceptsJson());
+        $this->assertEquals('https://testing', $request->url());
     }
 
     public function testFail(): void