Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Use natural_name setter to rename item in hdf5 file #800

Merged
merged 1 commit into from
Nov 28, 2018
Merged

ENH: Use natural_name setter to rename item in hdf5 file #800

merged 1 commit into from
Nov 28, 2018

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Nov 27, 2018

Closes #417

@ksunden ksunden self-assigned this Nov 27, 2018
@ksunden ksunden added this to the 3.2.0 milestone Nov 27, 2018
untzag
untzag approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@untzag untzag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work as always, @ksunden

WrightTools/_dataset.py Show resolved Hide resolved
@untzag untzag merged commit fbd46e2 into master Nov 28, 2018
@untzag untzag deleted the renaming branch November 28, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untzag untzag untzag approved these changes

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

@ddkohler ddkohler Awaiting requested review from ddkohler ddkohler is a code owner

Assignees

@ksunden ksunden

Labels
enhancement
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ksunden @untzag