Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chop patch #1095

Merged
merged 4 commits into from
Aug 4, 2022
Merged

chop patch #1095

merged 4 commits into from
Aug 4, 2022

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Aug 4, 2022 •
edited
Loading

Changes

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ksunden
Copy link
Member

ksunden commented Aug 4, 2022

LGTM, I would run the attune tests off of this branch and honestly just do another release (can even be in this same PR) because its a bug that affects our current usage.

@ddkohler ddkohler marked this pull request as ready for review August 4, 2022 05:10
@ddkohler
Copy link
Contributor Author

ddkohler commented Aug 4, 2022

attune tests pass; good to go

@ksunden ksunden merged commit 49501c4 into master Aug 4, 2022
@ksunden ksunden deleted the chop-patch branch August 4, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@untzag untzag Awaiting requested review from untzag untzag is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

@kameyer226 kameyer226 Awaiting requested review from kameyer226 kameyer226 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chop fails when axes do not span data shape
2 participants
@ddkohler @ksunden