chop respects axis order of args #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddkohler
requested review from
untzag,
ksunden,
darienmorrow and
kameyer226
as code owners
ksunden
previously approved these changes
Jul 29, 2022
|
Well, I thought it looked good, but tests are failing... Initially wondered if it would handle the case of being passed ints in, but we make sure everything is strings at this point. |
|
I think you took the opposite meaning from my comment... I meant that I thought it was wrong initially, but upon closer inspection decided that it was correct because we translate the ints to strings. I did not think that was the error causing tests to fail... |
ksunden
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I am intentionally omitting a changelog entry since this bug is not present in any version.
Checklist