enable compression #1085
Merged
enable compression #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ksunden
commented
Jul 19, 2022
|
Dataset is (51, 61, 551) with array detector for the last axis, all other datasets are just 51x61 original file (without any compression): 34 MB compression while collecting: 7.0 MB |
| @@ -31,6 +33,13 @@ | |||
| d.create_channel(name="w1") | |||
|
|
|||
|
|
|||
| def test_create_compressed_channel(): | |||
| data = wt.Data() | |||
| child1 = data.create_channel("hi", shape=(1024, 1024), compression="gzip") | |||
Check notice
Code scanning / CodeQL
Unused local variable
ksunden
requested review from
untzag,
ddkohler,
darienmorrow and
kameyer226
as code owners
kameyer226
requested changes
Jul 27, 2022
untzag
approved these changes
Jul 27, 2022
|
honestly I'm not interested in testing data integrity, that is h5py's job, which I trust them greatly to do... The test is simply proving that it is indeed applied to begin with. |
|
ok |
kameyer226
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enable passing compression/compression opts/shuffle arguments to h5py
require_datasetInitially this is posted to allow testing in bluesky-in-a-box, so draft without any tests/docs added yet
Closes #422
Checklist