Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure artists.quickND plotters always close chopped data files #1080

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Jun 22, 2022

Changes

Wrap the implementations of quick1D and quick2D with a closing context manager for the chopped collection

Checklist

  • added tests, if applicable... I wish testing this in pytest was easier, but it would rely on some weirdness that I don't know if I want to rely on
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ksunden ksunden marked this pull request as ready for review June 23, 2022 16:12
@ksunden
Copy link
Member Author

ksunden commented Jun 23, 2022

Unfortunately this did not actually fix the behavior I was trying to address, though it remains a good change that should be included in my opinion (just not the silver bullet I hoped it'd be)

Copy link
Contributor

@ddkohler ddkohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a great way to test this code other than verifying quicknD still works for me (which it seems to). lgtm

@ddkohler ddkohler merged commit 12d784f into wright-group:master Aug 3, 2022
@ksunden
Copy link
Member Author

ksunden commented Aug 3, 2022

The diff is large, but only because of whitespace, its basically just ensuring that data objects which get opened by quick functions are closed explicitly and don't just hang out waiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants