Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fft: satisfy Plancherel #1075

Merged
merged 12 commits into from
Jun 12, 2022
Merged

fft: satisfy Plancherel #1075

merged 12 commits into from
Jun 12, 2022

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Jun 10, 2022

Changes

Spectral intensity across all colors should be equal to intensity across all time.
Resolves #1076 .

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ddkohler ddkohler changed the title WIP: fft: satisfy Plancherel fft: satisfy Plancherel Jun 11, 2022
@ddkohler ddkohler marked this pull request as ready for review June 11, 2022 19:58
@ksunden
Copy link
Member

ksunden commented Jun 12, 2022

https://numpy.org/doc/stable/reference/generated/numpy.fft.fft.html#numpy.fft.fft

Somewhat curious if simply passing norm="ortho" has the same effect?

@ddkohler
Copy link
Contributor Author

https://numpy.org/doc/stable/reference/generated/numpy.fft.fft.html#numpy.fft.fft

Somewhat curious if simply passing norm="ortho" has the same effect?

No, I think their norm argument relates to unitary vs. non-unitary definitions. https://numpy.org/doc/stable/reference/routines.fft.html#normalization

Note that np.fft.fft cannot incorporate this feature because it does not accept x-axis/spacing as an argument.

@ddkohler ddkohler merged commit b4f186a into master Jun 12, 2022
@ddkohler ddkohler deleted the fft branch June 12, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

kit.fft: fourier coefficients ignore x-axis spacing
3 participants