FLAG-1210: replace carto query with precalculated table for soil organic widget #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wri7tno
force-pushed
the
feat/FLAG-1210
branch
from
2cde61c to
2d64344
Compare
wri7tno
force-pushed
the
feat/FLAG-1210
branch
from
d47552d to
671ab73
Compare
willian-viana
approved these changes
Feb 3, 2025
| @@ -2747,6 +2749,55 @@ export const getBiomassStock = (params) => { | |||
| })); | |||
| }; | |||
|
|
|||
| export const getSoilOrganicCarbon = (params) => { | |||
There was a problem hiding this comment.
Is there a reason to remove this method from the climate.js file to add it here?
There was a problem hiding this comment.
that file was using carto, but I can move it to that file if we want to clean up this one
There was a problem hiding this comment.
although it follows the very same logic all other functions in this file do, like using the sql queries at the top of the file and whatnot
…il organic widget
wri7tno
force-pushed
the
feat/FLAG-1210
branch
from
671ab73 to
be2396c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing