[FLAG-1128] Incorrect query in weekly VIIRS alert widget #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wri7tno
reviewed
Jun 24, 2024
| @@ -71,7 +72,7 @@ export const getData = createSelector( | |||
| }; | |||
|
|
|||
| years.forEach((year) => { | |||
| const yearDataByWeek = groupBy(groupedByYear[year], 'week'); | |||
| const yearDataByWeek = toArray(groupBy(groupedByYear[year], 'week')); | |||
Recharts uses dataKey to set the unique value displayed at XAxis. We were using date for it but hiding most part to display only 12 dates Now we are using month and setting it as a unique value
…ty monthLabel to XAxis dataKey
Now when the user selects confidence 'all' we count the alerts for the three different confidence levels
willian-viana
force-pushed
the
fix/weekly-fire-alerts-FLAG-1128
branch
from
06d3691 to
8a4ec20
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In Slack, Jimmy noted that something seems to be wrong with weekly VIIRS alert widget; he thinks it is a front end issue and has to do with the way it is being queried. The downloaded data looks correct and has data through this week.
Alongside this task, new bugs were found.
Example from Yukon, Canada:
Demo