Fixed restart problem for tmn_update option #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I asked Kelly to use her case to test some new WTF options, but my efforts ran into trouble, so the regression test is not yet completed. We'll discuss this change next week. |
davegill
reviewed
Sep 16, 2016
There was a problem hiding this comment.
Kelly,
Two items:
- This has been identified as a serious issue. What code versions are impacted? Is there a simple way to address this problem in earlier versions of the code?
- If the group most impacted by this bug are those dealing with regional climate (seems likely that a 2-day forecast may not even notice 0 K deep soil temp), that should be explicitly stated.
|
WTF passes ✔️ |
mkavulich
approved these changes
Sep 23, 2016
davegill
added a commit
that referenced
this pull request
May 24, 2018
TYPE: no impact KEYWORDS: version_decl, version SOURCE: internal DESCRIPTION OF CHANGES: Update version to indicate 4th friendly release. This will be what we use for testing during our time when we consider the repo frozen (at least pretty slushy). LIST OF MODIFIED FILES: M inc/version_decl TESTS CONDUCTED: 1. No tests, but we will be running a bunch of them pretty soon.
davegill
added a commit
to smileMchen/WRF
that referenced
this pull request
Feb 10, 2020
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 15, 2021
Added capability to force mesoscale simulations using the module_sf_s…
janmandel
added a commit
to wrf-sfire/WRF-SFIRE
that referenced
this pull request
Feb 5, 2022
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 13, 2022
Adding tslist to output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix - posted
KEYWORDS: tmn_update, restart, Registry, Registry.EM_COMMON, regional climate
SOURCE: Heimo Truhetz of University of Graz, Austria
DESCRIPTION OF CHANGES:
Added a "r" in the registry line for TLAG to add variable to restart files. Since TLAG was left out of the restart file, any restart using the tmn_update option started with 0 K as the lower boundary condition for the land model. When running long simulations (i.e, regional climate runs), this caused the soil temperature to cool gradually, eventually affecting the skin and atmospheric temperature. This change corrects the problem.
This has been an issue since Version 3.7.
LIST OF MODIFIED FILES : Registry/Registry.EM_COMMON
TESTS CONDUCTED : Tests conducted to ensure problem is corrected. Regression test is pending.