Removing some debug-level prints from RRTMG lw #3

dudhia · 2016-09-15T16:08:06Z

TYPE: no impact

KEYWORDS: remove some debug-level prints

SOURCE: internal

DESCRIPTION OF CHANGES:
Debug-level 150 prints were printing at too many grid points, and are not useful.
These will be commented out.

LIST OF MODIFIED FILES :
phys/module_ra_rrtmg_lw.F
phys/module_ra_rrtmg_lwf.F

TESTS CONDUCTED:
None.

jamiebresch · 2016-09-15T20:31:36Z

Will the prints be useful in any case?
If yes, then maybe set a higher debug level for it?
If no, why not simply remove the code.

dudhia · 2016-09-15T20:37:25Z

I can't think of any use for these prints because it is the same
information for every grid point.
I can see a case for deleting them.
Jimy

On Thu, Sep 15, 2016 at 2:31 PM, Jamie Bresch [email protected]
wrote:

Will the prints be useful in any case?
If yes, then maybe set a higher debug level for it?
If no, why not simply remove the code.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARGf_B-hGPDjJaBNDnhbjA1o5DKa0u39ks5qqaspgaJpZM4J-DO6
.

davegill · 2016-09-16T18:53:48Z

phys/module_ra_rrtmg_lw.F

@@ -12018,10 +12018,10 @@ SUBROUTINE RRTMG_LWRAD(                                        &
 !Mukul change the flags here with reference to the new effective cloud/ice/snow radius
         IF (ICLOUD .ne. 0) THEN
            IF ( has_reqc .ne. 0) THEN
-               IF ( wrf_dm_on_monitor() ) THEN
-                 WRITE(message,*)'RRTMG: pre-computed cloud droplet effective radius found, setting inflglw=3'
-                 call wrf_debug(150, message)


Jimy,
These are already at level 150, and they are formatted exactly as we ask people to do. Do these messages appear to often when the debug level is set to 150 (as in every time through the scheme)? Hardly anyone runs with debug this high, so these messages should not be problematic for most people.
Dave

dudhia · 2016-09-16T19:01:21Z

Yes, it is almost every grid point.

On Fri, Sep 16, 2016 at 12:53 PM, Dave Gill [email protected]
wrote:

@davegill commented on this pull request.

In phys/module_ra_rrtmg_lw.F
#3 (review):
@@ -12018,10 +12018,10 @@ SUBROUTINE RRTMG_LWRAD( &
!Mukul change the flags here with reference to the new effective cloud/ice/snow radius
IF (ICLOUD .ne. 0) THEN
IF ( has_reqc .ne. 0) THEN
          IF ( wrf_dm_on_monitor() ) THEN
            WRITE(message,*)'RRTMG: pre-computed cloud droplet effective radius found, setting inflglw=3'
            call wrf_debug(150, message)
Jimy,
These are already at level 150, and they are formatted exactly as we ask
people to do. Do these messages appear to often when the debug level is set
to 150 (as in every time through the scheme)? Hardly anyone runs with debug
this high, so these messages should not be problematic for most people.
Dave

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARGf_Arwnwf5a9UvuGOgK2PnWaf9w16Zks5qquW9gaJpZM4J-DO6
.

mkavulich · 2016-09-16T19:31:16Z

Developer's committee requests deleting these lines instead of commenting them out.

TYPE: no impact KEYWORDS: remove some debug-level prints SOURCE: internal DESCRIPTION OF CHANGES: Debug-level 150 prints were printing at too many grid points, and are not useful. These will be deleted. LIST OF MODIFIED FILES : phys/module_ra_rrtmg_lw.F phys/module_ra_rrtmg_lwf.F TESTS CONDUCTED: None. (cherry picked from commit ba46355)

KEYWORDS: rebalance SOURCE: Katie Lundquist (LLNL) PURPOSE: For vertical refinement, a rebalancing step reduces noise in both high resolution LES cases and in nested hurricane cases. DESCRIPTION OF CHANGES: In module_dm.F, the intermediate domain is rebalanced after vertical interpolation. Also, for consistency, the method of integrating the perturbation fields in start_em.F is used in the init for real. The LES case gets the removal of the reciprocal 1/RDNW, and the option of which way to compute ALB. LIST OF MODIFIED FILES (annotated if not obvious, not required to be on a single line): M Registry/Registry.EM_COMMON Add two new variables to the Registry namelist: 1) rebalance in namelist &domains 0=NO 1=always YES 2=only YES with vertical nesting 2) ideal_init_method in &domains, immpacts code in start_em.F 0=ALB from PHB (original) 1=ALB from T_INIT M dyn_em/module_initialize_les.F 1) swap blah/RDNW(k) for blah*DNW(k), two locations M dyn_em/module_initialize_real.F 1) Test if the rebalance option is switched on. If so, with the newly available Qv, recompute the pressure. M dyn_em/start_em.F 1) Do we do the rebalancing 2) Clean up the if test explanations a bit, and label the endif parts so we know what just happened in the code 3) swap the order of an if test and an OpenMP loop, no need to do an OpenMP loop if the if test is always going to be false. M external/RSL_LITE/module_dm.F 1) For vertical nesting, vertically interpolate for ideal cases on intermediate domain. 2) rebalance to get a new geopotential for vertical nesting TESTS CONDUCTED (explicitly state mandatory, voluntary, and assigned tests, not required to be on a single line): 1) Regression test - do no harm 2) Katie did the summer and winter test cases, and sent along a PPT to review, without vertical refinement, no harm done. 3) Katie also conducted sensitivity tests using vertical refinement to show noise in both very-high resolution cases (LES), and in resolutions that others tend to use (1-10 km nested cases over flat terrain for huricanes). 4) Bit-wise identical results for ALMOST all non-vertically refined tests, these are the same bit-for-bit differences when comparing versions of the WRF code that modified diagnostic print statements only. Total number of identical file tests: 1397 Total number of different file tests: 160 We expect all of the tests with vertical refinement to be different. If we remove those from the list of diffs, then this is our list of failed bit-wise identical results: List of bit-wise (before the mods vs after the mods) failures TROUBLE, ---> the two wrf_9162.34/em_real/wrf_regression.namelist.input.65 wrfout_d01 files are different TROUBLE, ---> the two wrf_9162.34/nmm_hwrf/wrf_regression.namelist.input.3 wrfout_d01 files are different TROUBLE, ---> the two wrf_9162.54/em_real/wrf_regression.namelist.input.65NE wrfout_d01 files are different TROUBLE, ---> the two wrf_9162.54/nmm_hwrf/wrf_regression.namelist.input.3 wrfout_d01 files are different The HWRF test #3 is able to get bit-wise different answers with GNU 4.9.2 on repeated runs. We never do a serial vs DM comparison for HWRF. Tests for the entire HWRF operational system are done only with Intel compilers, so the bit-wise diffs for non-Intel compilers is not really too much of a surprise. git-svn-id: https://svn-wrf-model.cgd.ucar.edu/trunk@9163 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d

TYPE: text only KEYWORDS: version, fr3 SOURCE: internal DESCRIPTION OF CHANGES: Update the inc/version_decl file to indicate that this is the third friendly release, and we are getting CLOSE! LIST OF MODIFIED FILES: M inc/version_decl TESTS CONDUCTED: 1. Code compiles, good enough for this change.

TYPE: bug fix KEYWORDS: GOCART, settling SOURCE: Stacy Walters (internal) DESCRIPTION OF CHANGES: Put calculation of aerosol settling (variable = transfer_to_below_level) in layers > 1 into IF/ELSE block that calculates gravitational settling for layer = 1. LIST OF MODIFIED FILES: M chem/module_gocart_settling.F TEST CONDUCTED: Jenkins shows all tests PASS **Compiled with debug option -check bounds** _BEFORE FIX_: 2 indexes are OOB for l==1, 3rd dim of delz (> MAX) and 3rd dim of airden (0) rsl.out.0000 l/=1, calculting transfer_to_below_level = 3.153560196907218E-014 l/=1, calculting transfer_to_below_level = 1.014890436929303E-012 l/=1, calculting transfer_to_below_level = 2.118741307102124E-011 l==1, still calculating transfer_to_below_level = = (temp_tc*vd_wk1)*((delz(i,j,l2)*airden(i,j,l))/(delz(i,j,l2+1)*airden(i,j,l-1))) l==1, index of airden(i,j,l-1) = 1 1 0 and index of delz(i,j,l2+1) = 1 1 31 but size of 3rd dim of delz = 30 rsl.error.0000 forrtl: severe (408): fort: (2): Subscript #3 of the array DELZ has value 31 which is greater than the upper bound of 30 _AFTER FIX_: l/=1, calculating transfer_to_below_level = 3.153560196907218E-014 l/=1, calculating transfer_to_below_level = 1.014890436929303E-012 l/=1, calculating transfer_to_below_level = 2.118741307102124E-011 l==1, not calculating transfer_to_below_level

Hotfix/pmi convective

…t.nc; ../fire.exe wrf-model#3

…-model#45

…-model#3 wrf-model#45

wrf-model#3

… in init_fuels_cat wrf-model#45 wrf-model#3

Changes for 160915

eff5076

davegill reviewed Sep 16, 2016

View reviewed changes

Changes for 160916

80ed900

dudhia merged commit ba46355 into wrf-model:master Sep 16, 2016

davegill mentioned this pull request Nov 9, 2016

Reduce computational patch size for intermediate domain for vertical nesting #37

Merged

davegill mentioned this pull request Dec 22, 2016

Include WENO and WENO+PD in advection kernel #79

Merged

davegill mentioned this pull request May 16, 2019

Support for compiling on cygwin #911

Closed

rmfonsecaweb mentioned this pull request Jun 4, 2019

Precipitating Convective Cloud (PCC): cloud-radiation feedbacks for BMJ Cumulus Scheme #921

Merged

jordanschnell mentioned this pull request Mar 6, 2020

Prevent 0 index in GOCART settling array #1113

Merged

dmey referenced this pull request in TEB-model/wrf-teb Mar 31, 2020

fix netcdf-c branch name (fixes #3)

6bfa6a5

Tuanph1970 mentioned this pull request Aug 18, 2020

Could not open new netcdf file structure #1274

Open

cxyiyh mentioned this pull request Nov 1, 2020

When I run /chem/convert_emiss.exe,the error occurs. #1310

Open

cenlinhe mentioned this pull request Nov 4, 2020

WRF-urban updates for the next WRF release #1309

Closed

dwongepa mentioned this pull request Mar 14, 2021

CMAQ-WRF coupling #1432

Closed

htan2013 mentioned this pull request Sep 6, 2021

Received signal SIGFPE(8) when initializing WRF4.3 with ERA5 and modis data #1549

Open

davegill added a commit to MicroTed/WRFV4 that referenced this pull request Sep 16, 2021

par2 test wrf-model#3 reggie 13:47

94fb542

jinjiuping mentioned this pull request Dec 27, 2021

Program received signal SIGABRT: Process abort signal. #1620

Closed

mefrediani mentioned this pull request Feb 10, 2022

MP38 Thompson 2-mom graupel/hail #1667

Closed

mefrediani mentioned this pull request Mar 1, 2022

PBL and LES using feedback =1 #1690

Open

twjuliano pushed a commit to twjuliano/WRF that referenced this pull request Jun 13, 2022

Merge pull request wrf-model#3 from jsauer-NCAR/hotfix/PMI-convective

d984a25

Hotfix/pmi convective

weiwangncar mentioned this pull request Oct 4, 2022

NoahMP bug fix #1767

Merged

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

some changes towards compiling standalone wrf-model#3

cbd2e55

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

adding variables, does not compile yet wrf-model#3

26fe946

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

running: em_fire/hill> ln -s wrfout_d01_0001-01-01_00:00:00 fire_inpu…

851b6ed

…t.nc; ../fire.exe wrf-model#3

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

Merge branch 'develop-3' into develop-45 wrf-model#3 wrf-model#45

691d84e

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

creating fuels.m for Balbi by init_fuel_cats wrf-model#45 wrf-model#3

bb23d51

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

finalize making fire_ros.exe and README in standalone wrf-model#3 wrf…

c2b394c

…-model#45

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

standalone fire_ros.exe goes through for both Rothermel and Balbi wrf…

a8b17e4

…-model#3 wrf-model#45

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

finalizing standalone/fire_ros_main.F wrf-model#3 wrf-model#45

7277b4c

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

handling of params in standalone fire_ros_main wrf-model#3 wrf-model#45

9388fff

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

hill same result as master, updating standalone/README.txt wrf-model#45

71c62ae

wrf-model#3

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

hill same numbers as master 81d4ab6 wrf-model#45 wrf-model#3

0edd81d

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

mv namelist out of executable section wrf-model#3 source: Robert Pasken

6ca3990

fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022

set fire_fmc_read = 0 in fire_ros_main.F to prevent overwing of fmc_f…

8653c97

… in init_fuels_cat wrf-model#45 wrf-model#3

maxibaka mentioned this pull request Jul 20, 2024

Segmentation fault when sf_urban_physics=2or3 #2083

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing some debug-level prints from RRTMG lw #3

Removing some debug-level prints from RRTMG lw #3

dudhia commented Sep 15, 2016

jamiebresch commented Sep 15, 2016

dudhia commented Sep 15, 2016

davegill Sep 16, 2016

dudhia commented Sep 16, 2016

@davegill commented on this pull request.

mkavulich commented Sep 16, 2016

Removing some debug-level prints from RRTMG lw #3

Removing some debug-level prints from RRTMG lw #3

Conversation

dudhia commented Sep 15, 2016

jamiebresch commented Sep 15, 2016

dudhia commented Sep 15, 2016

davegill Sep 16, 2016

Choose a reason for hiding this comment

dudhia commented Sep 16, 2016

@davegill commented on this pull request.

mkavulich commented Sep 16, 2016