Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dzstretch_u and dzbot to namelist.input in test/em_real/ #2165

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

weiwangncar
Copy link
Collaborator

TYPE: enhancement, no impact, text only

KEYWORDS: vertical coordinate, namelist

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The current namelist.input file only has dzstretch_s. To properly use the auto_levels_opt, dzstretch_u and dzbot should be considered.

Solution:
Add dzstretch_u and dzbot in the namelist. Parameters based on UG.

LIST OF MODIFIED FILES:
M test/em_real/namelist.input

TESTS CONDUCTED:
2. Are the Jenkins tests all passing?

RELEASE NOTE: Add dzstretch_u and dzbot in namelist.input. Users are advised to check UG for other parameters to use.

@dudhia
Copy link
Collaborator

dudhia commented Feb 6, 2025

we might have a release branch already

@weiwangncar
Copy link
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
Copy link
Collaborator Author

@dudhia I can add it to the release branch if approved.

@dudhia
Copy link
Collaborator

dudhia commented Feb 6, 2025

It is a slightly odd choice to have such a small difference between the factors. Was this used in a project?

@weiwangncar
Copy link
Collaborator Author

It is a slightly odd choice to have such a small difference between the factors. Was this used in a project?

I determined those by running real and looking at the variations of the thickness values printed out.

@weiwangncar weiwangncar merged commit 89ba518 into wrf-model:develop Feb 7, 2025
1 check passed
@weiwangncar weiwangncar deleted the nml2 branch February 7, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants