-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of stability functions for the tke-epsilon-tpe PBL scheme #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency with other pbl schemes
Can you say something about the effect of this change in the release notes? |
Updated. I have some plots if needed |
Thanks. It didn't make it in time for 4.6.1 but we hope to have it for
4.6.2,
Jimy
…On Fri, Oct 18, 2024 at 3:47 AM andreazonato ***@***.***> wrote:
Can you say something about the effect of this change in the release notes?
Updated. I have some plots if needed
—
Reply to this email directly, view it on GitHub
<#2120 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77G2V6G6KFRFKW7IHEDZ4DKMLAVCNFSM6AAAAABQBH572KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRSGAYDIMRSHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
dudhia
approved these changes
Dec 12, 2024
dudhia
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug fix only
need to check if this passed tests |
It did. This is the regression test results:
|
weiwangncar
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: tke-epsilon-tpe, PBL, stability functions
SOURCE: Andrea Zonato, Royal Netherlands Meteorological Institute (KNMI)
DESCRIPTION OF CHANGES:
Problem:
The stability functions at the surface (phim,phieps) for calculating the boundary values of tke and its dissipation rate in the tke-epsilon-tpe PBL scheme Zonato et al., 2022 does not include the correction by z0.
Solution:
Pass the correct stability functions, calculated in module_sf_sfclayrev.F
LIST OF MODIFIED FILES:
phys/module_bl_keps.F
phys/module_pbl_driver.F
TESTS CONDUCTED:
The Jenkins tests are all passing.
RELEASE NOTE:
The similarity stability functions phim and phieps, necessary for calculating the surface values of tke and dissipation rate in the tke-epsilon-tpe PBL scheme Zonato et al., 2022 have been updated considering the correction term accounting for the roughness length z0. No relevant differences are found in temperature, wind speed, and humidity. Regarding turbulence variables, the stable case has just negligible differences, while the unstable case shows higher values of TKE and dissipation rate and lower values of temperature variance.