Fixing typographic errors in the WRFDA code #2

mkavulich · 2016-09-09T17:03:19Z

TYPE: text only

KEYWORDS: WRFDA

SOURCE: internal

DESCRIPTION OF CHANGES:
There are several typos in the WRFDA code that needed fixing. This does not impact results.

LIST OF MODIFIED FILES:
M var/da/da_main/da_solve.inc
M var/da/da_main/da_update_firstguess.inc
M var/da/da_main/da_wrfvar_main.f90
M var/da/da_setup_structures/da_setup_be_ncep_gfs.inc
M var/da/da_transfer_model/da_transfer_wrftltoxa_adj.inc

TESTS CONDUCTED: None, text-only change.

mgduda · 2016-09-09T17:15:11Z

@mkavulich Is there any reason to not squash the two commits in this PR into just one commit?

jamiebresch · 2016-09-09T17:15:35Z

Since it is about fixing typos, could you also fix "assmiilation"
! 1.2.1 Surface assmiilation approach 2(10-m u, v, 2-m t, q,
var/da/da_buoy/da_get_innov_vector_buoy.inc
! [2.0] Surface assmiilation approach 2
var/da/da_buoy/da_transform_xtoy_buoy.inc
! [2.0] Surface assmiilation approach 2
var/da/da_metar/da_transform_xtoy_metar.inc
! Purpose: Output data assmiilation diagnostics
var/da/da_minimisation/da_write_diagnostics.inc
! 2.0 Surface assmiilation approach 2 (2-m t and q, 10-m u and v)
var/da/da_physics/da_transform_xtopsfc.inc
! 1.2.1 Surface assmiilation approach 2(10-m u, v, 2-m t, q, and
var/da/da_ships/da_get_innov_vector_ships.inc
! [2.0] Surface assmiilation approach 2
var/da/da_ships/da_transform_xtoy_ships.inc
! The use of surface observations in four dimensional data assmiilation
var/da/da_tools/da_intpsfc_tem.inc
! Background qrn needed for radar radial velocity assmiilation:
var/da/da_transfer_model/da_transfer_wrftoxb.inc

mkavulich · 2016-09-09T17:36:15Z

@jamiebresch Good idea, working on that now

…es (assmiilation -> assimilation). Found a few more typos along the way as well.

jamiebresch · 2016-09-09T17:59:00Z

var/da/da_transfer_model/da_transfer_wrftoxb_lite.inc is not actually used.
Its content is way out-of-date and its purpose is unknown.
There is no point touching that file. We should consider removing it in the future.

davegill · 2016-09-09T18:04:06Z

var/da/da_main/da_wrfvar_main.f90

@@ -23,7 +23,7 @@ program da_wrfvar_main

   implicit none

-   ! Split initialisation into 2 parts so we can start and stop trace here
+   ! Split initialization into 2 parts so we can start and stop trace here


There are zillions of British spellings of initialisation within DA. I'd say leave these alone. Here's a grep in the var directory ...

find . -name *.inc -exec grep -i initialis {} ; -print > foo.txt

! Initialise columns k+1:n to columns of the unit matrix
./external/lapack/dorg2r.inc
! Initialise columns 1:n-k to columns of the unit matrix
./external/lapack/dorg2l.inc
! [1.0]: Initialise:
./da/da_tools/da_1d_eigendecomposition.inc
! [1.0] Initialise components of innovation vector:
./da/da_obs/da_setup_pseudo_obs.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures_rain.inc
! [1.0] Initialise random number sequence:
./da/da_obs/da_random_omb_all.inc
! Initialise obs error factors (which will be overwritten in use_obs_errfac)
./da/da_obs/da_fill_obs_structures_radar.inc
! [2.0] Initialise components of innovation vector:
./da/da_ssmi/da_get_innov_vector_ssmt1.inc
! [3.0] Calculate rv, rf at OBS location and initialise components of &
./da/da_radar/da_get_innov_vector_radar.inc
! [2.0] Initialise components of innovation vector:
./da/da_rain/da_get_innov_vector_rain.inc
! [1.0] Initialise bins:
./da/da_statistics/da_data_distribution.inc
! [1.0] Initialise:
./da/da_define_structures/da_allocate_background_errors.inc
! Purpose: Initialises the Y-array
./da/da_define_structures/da_zero_y.inc
! [2.0] Initialise components of innovation vector:
./da/da_sound/da_get_innov_vector_sound.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_recursive_filter_1d_adj.inc
! [1.0]: Initialise:
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_adj_dual_res.inc
! [1.0]: Initialise:
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_adj.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf_dual_res.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_transform_through_rf.inc
! [1.0]: Initialise:
./da/da_recursive_filter/da_calculate_rf_factors.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_apply_rf_1v.inc
! [1.0] Initialise:
./da/da_recursive_filter/da_recursive_filter_1d.inc
! [2.0] Initialise components of innovation vector:
./da/da_tamdar/da_get_innov_vector_tamdar.inc
! [1.0] Initialise:
./da/da_setup_structures/da_get_vertical_truncation.inc
! 5.0 Initialise control variable space components of header:
./da/da_setup_structures/da_setup_be_regional.inc
! [1.0] Initialise:
./da/da_setup_structures/da_rescale_background_errors.inc
! 4.0 Initialise control variable space components of header:
./da/da_setup_structures/da_setup_be_nmm_regional.inc
! [1.0] Initialise:
./da/da_test/da_check_cvtovv_adjoint.inc
! [1.0] Initialise:
./da/da_test/da_check_vvtovp_adjoint.inc
! [1.0] Initialise:
./da/da_test/da_check_vtox_adjoint.inc
! [1.0]: Initialise:
./da/da_test/da_check_balance.inc
! [1.0] Initialise:
./da/da_test/da_check_xtoy_adjoint.inc
! [1.0]: initialise:
./da/da_test/da_setup_testfield.inc
! [1.0] Initialise:
./da/da_test/da_check_vptox_adjoint.inc
! initialise index:
./da/da_tracing/da_trace_int_sort.inc
! Purpose: Initialise tracing
./da/da_tracing/da_trace_init.inc
! initialise index:
./da/da_tracing/da_trace_real_sort.inc
! [2.0] Initialise components of innovation vector:
./da/da_mtgirs/da_get_innov_vector_mtgirs.inc
! [2.0] Initialise wrfvar parameters:
./da/da_main/da_solve.inc
! [2.0] Initialise components of innovation vector:
./da/da_profiler/da_get_innov_vector_profiler.inc
! [2.0] Initialise components of innovation vector:
./da/da_pilot/da_get_innov_vector_pilot.inc
! [2.0] Initialise components of innovation vector:
./da/da_bogus/da_get_innov_vector_bogus.inc
! [2.0] Initialise components of innovation vector:
./da/da_airsr/da_get_innov_vector_airsr.inc
! [2.0] Initialise components of innovation vector:
./da/da_airep/da_get_innov_vector_airep.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fct.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fct_adj.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fst_adj.inc
! [1.0] Initialise:
./da/da_ffts/da_solve_poissoneqn_fst.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_iasi.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_airs.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_hirs.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_atms.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_mwts.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_seviri.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_amsua.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_amsr2.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_mwhs.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_mhs.inc
gooddata_map(i,j) = .TRUE. ! Initialised for step 6)
./da/da_radiance/ATMS_Spatial_Average.inc
! 0.0 initialise QC by flags assuming good obs
./da/da_radiance/da_qc_ssmis.inc
! 0.0 initialise QC flags by assuming good obs
./da/da_radiance/da_qc_amsub.inc
x = 0.5*(x1 + x2) ! Initialise the guess for the root
./da/da_spectral/da_get_gausslats.inc
! Initialise Power spectrum
./da/da_spectral/da_test_spectral.inc
! Initialise the varibles
./da/da_gpspw/da_transform_xtoy_gpsztd_adj.inc
! Initialise the varibles
./da/da_gpspw/da_transform_xtoy_gpspw_adj.inc
! [1.0]: Initialise:
./da/da_vtox_transforms/da_check_eof_decomposition.inc
! [1.0] Initialise:
./da/da_vtox_transforms/da_transform_bal.inc
! [1.0] Initialise:
./da/da_vtox_transforms/da_transform_bal_adj.inc
! [2.0] Initialise components of innovation vector:
./da/da_metar/da_get_innov_vector_metar.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_adj.inc
! [1.0] Initialise i and set multiplicative constants
./da/da_dynamics/da_wpec_constraint.inc
! [1.0] Initialise i and set multiplicative constants
./da/da_dynamics/da_wpec_constraint_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_divergence.inc
! [1.0] Initialise iand set Multipilactive constants
./da/da_dynamics/da_balance_equation_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_geoterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_divergence_adj.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_wpec_constraint_cycloterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_uv_to_vorticity.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm_lin.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_equation_adj.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_geoterm.inc
! [1.0] Initialise:
./da/da_dynamics/da_balance_cycloterm_adj.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs_lin1.inc
! [1.0] initialise:
./da/da_physics/da_tprh_to_q_adj.inc
! [1.0] initialise:
! [1.0] initialise:
./da/da_physics/da_tp_to_qs1.inc
! [1.0] initialise:
./da/da_physics/da_prho_to_t_adj.inc
! [1.0] initialise:
./da/da_physics/da_tp_to_qs_adj.inc
! Purpose: Initialises the Y-array
./da/da_minimisation/da_calculate_j.inc
! [2.0] Initialise components of innovation vector:
./da/da_qscat/da_get_innov_vector_qscat.inc
! [4.0] Allocate and initialise residual structure:
./obsproc/MAP_plot/Dir_map/DA_Setup_Obs_Structures.inc

@davegill I changed that one because in the beginning of that same subroutine (a few lines earlier) the American spelling is used. But I can leave this one alone I guess.

jamiebresch · 2016-09-09T18:06:30Z

purtubation->perturbation
! pressure purtubation:
var/da/da_transfer_model/da_transfer_wrftoxb.inc

jamiebresch · 2016-09-09T18:07:18Z

dignostic->diagnostic
! Purpose: Transfers fields from WRF TL fields to dignostic fields needed by observational operators
var/da/da_vtox_transforms/da_transform_xtoxa.inc
! Purpose: Transfers fields from WRF TL fields to dignostic fields needed by observational operators
var/da/da_vtox_transforms/da_transform_xtoxa_adj.inc
! Purpose: Transfers fields from WRF TL fields to dignostic fields needed by observational operators
var/da/da_vtox_transforms/da_transform_xtoxa_adj_all.inc
! Purpose: Transfers fields from WRF TL fields to dignostic fields needed by observational operators
var/da/da_vtox_transforms/da_transform_xtoxa_all.inc

…case. (#9) * BRANCH commit: Development branch for Subashini Subramanian to work on adding landfall options to the HWRF idealized case. A https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9440 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * ideal land fall changes for initializing the domain with a defined strip of land from land.nml file git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9569 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * ideal landfall changes. contains code to update land surface boundary conditions. git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9570 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * ideal landfall changes. function to move land through sea mask control variable added. git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9571 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * ideal landfall changes. the speed with which land underneath moves is set here. subroutine move_land called. other land surface parameters are updated from land.nml file. git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9572 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * ideal landfall changes. appropriate changes for boundary condition updates for SM (Sea Mask). git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9573 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Initial commit git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF_ideal_landfall@9574 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Updates to idealized HWRF code, from Subashini modified: dyn_nmm/module_NEST_UTIL.F modified: dyn_nmm/module_initialize_tropical_cyclone.F modified: dyn_nmm/solve_nmm.F modified: test/nmm_tropical_cyclone/land.nml * Hwrf (#2) * MergeH216: copying HWRF branch to merge H216 changes to HWRF in preparation for merging to trunk git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9406 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Sync with revision 9364 of branch H216 git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9407 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Partially merged from OperH216 branch git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9444 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More merging git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9454 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More Merges and bug fixes git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9459 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More Merges and bug fixes git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9460 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More merging in ./frame git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9486 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More merging in ./phys git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9487 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * More merging in ./share git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9488 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * merge surface module git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9489 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * merge bug fix git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9490 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Bug fix in module_sf_gfdl.F git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9491 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Sync with OperH216 git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/MergeH216@9492 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Branch commit: added long and short wave heating rate variables git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF@9561 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * more complete output files using auxiliary stream 4 git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF@9563 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * changes for ER overlap from trunk code that is weeks old git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF@9565 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * Reverse merging changes made in error from JHenders. git-svn-id: https://svn-wrf-model.cgd.ucar.edu/branches/HWRF@9567 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d * set landfall to false for default * update namelists for V3.8a * Update history-output for sea mask (SM)

KEYWORDS: version update SOURCE: internal PURPOSE: Update version for pre-release #2 for v3.8. DESCRIPTION OF CHANGES: Modify the character string so that model data now reflects the pre-release #2. LIST OF MODIFIED FILES (annotated if not obvious, not required to be on a single line): M inc/version_decl TESTS CONDUCTED (explicitly state mandatory, voluntary, and assigned tests, not required to be on a single line): 1) Cavalierly not running anything at all. Index: version_decl =================================================================== --- version_decl (revision 9178) +++ version_decl (working copy) @@ -1 +1 @@ - CHARACTER (LEN=10) :: release_version = 'V3.8pre#1 ' + CHARACTER (LEN=10) :: release_version = 'V3.8pre#2 ' git-svn-id: https://svn-wrf-model.cgd.ucar.edu/trunk@9179 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d

TYPE: text only KEYWORDS: version, Friendly #2 SOURCE: internal DESCRIPTION OF CHANGES: Update version information in top-level README and version_decl to Friendly #2. LIST OF MODIFIED FILES: M README M inc/version_decl TESTS CONDUCTED: 1. No tests at all.

…#2) (#517) TYPE: bug fix KEYWORDS: RRTMG FAST, GNU SOURCE: internal DESCRIPTION OF CHANGES: With GNU version 6.4.0, 6.5.0, 7.1.0, 7.2.0, and 7.3.0, the WRF RRTMG FAST LW scheme causes an internal compiler error for some optimization levels. The RRTMG code looks reasonable, so there does not seem an obvious code fix to implement in the RRTMG FAST LW scheme. ``` module_ra_rrtmg_swf.f90:5612:0: use rrsw_kg21_f, only : kao, kbo, selfrefo, forrefo, sfluxrefo, & internal compiler error: in gfc_trans_use_stmts, at fortran/trans-decl.c:4920 module_ra_rrtmg_swf.f90:5612:0: internal compiler error: Abort trap: 6 gfortran: internal compiler error: Abort trap: 6 (program f951) ``` The solution is to BE EASILY ABLE TO remove the RRTMG FAST code via an ifdef. LIST OF MODIFIED FILES: M phys/module_physics_init.F M phys/module_ra_rrtmg_lwf.F M phys/module_ra_rrtmg_swf.F M phys/module_radiation_driver.F M share/module_check_a_mundo.F M arch/postamble TESTS CONDUCTED: - [x] Code builds with GNU/7.2.0 with -D optimization with mods (i.e. NO RRTMG FAST) - [x] Code does not build with newer GNU with -D optimization without mods

… data (#875) TYPE: bug fix KEYWORDS: LBC, valid time SOURCE: identified by Michael Duda (NCAR/MMM), fixed internally DESCRIPTION OF CHANGES: Problem: 1. If a user tried to start a simulation _after_ the last LBC valid period, the WRF model would get into a nearly infinite loop and print out repeated statements: ``` THIS TIME 2000-01-24_18:00:00, NEXT TIME 2000-01-25_00:00:00 d01 2000-01-25_06:00:00 Input data is acceptable to use: wrfbdy_d01 2 input_wrf: wrf_get_next_time current_date: 2000-01-24_18:00:00 Status = -4 d01 2000-01-25_06:00:00 ---- ERROR: Ran out of valid boundary conditions in file wrfbdy_d01 ``` 2. If a user tries to extend the model simulation beyond that valid times of the LBC, the code behavior is not controlled (nearly infinite loops on some machines, or runtime errors with a backtrace on other machines). Solution: In another routine, the lateral boundary condition is read to get to the correct time. Once inside of share/input_wrf.F, we should be at the correct time. There is no need to try to get to the next time. In this particular case, the effort to get to the next time fails, but we try again (and again and again). This solution fixes both problems identified above. ISSUE: Fixes #769 "WRF doesn't halt when beginning LBC time is not in wrfbdy_d01 file" LIST OF MODIFIED FILES: M share/input_wrf.F TESTS CONDUCTED: 1. Without fix, start the model after the last valid time of the LBC file => lots of repeated messages ``` THIS TIME 2000-01-24_18:00:00, NEXT TIME 2000-01-25_00:00:00 d01 2000-01-25_06:00:00 Input data is acceptable to use: wrfbdy_d01 2 input_wrf: wrf_get_next_time current_date: 2000-01-24_18:00:00 Status = -4 d01 2000-01-25_06:00:00 ---- ERROR: Ran out of valid boundary conditions in file wrfbdy_d01 ``` 2. With this fix, when LBC stops at 2000 01 25 00, and WRF starts at 2000 01 25 06 ``` d01 2000-01-25_06:00:00 Input data is acceptable to use: wrfbdy_d01 THIS TIME 2000-01-24_12:00:00, NEXT TIME 2000-01-24_18:00:00 d01 2000-01-25_06:00:00 Input data is acceptable to use: wrfbdy_d01 THIS TIME 2000-01-24_18:00:00, NEXT TIME 2000-01-25_00:00:00 d01 2000-01-25_06:00:00 Input data is acceptable to use: wrfbdy_d01 2 input_wrf: wrf_get_next_time current_date: 2000-01-24_18:00:00 Status = -4 -------------- FATAL CALLED --------------- FATAL CALLED FROM FILE: <stdin> LINE: 1134 ---- ERROR: Ran out of valid boundary conditions in file wrfbdy_d01 ------------------------------------------- ``` 3. Without this fix, if we try to extend the module simulation beyond the valid lateral boundary times ``` Timing for main: time 2000-01-24_23:54:00 on domain 1: 0.53782 elapsed seconds Timing for main: time 2000-01-24_23:57:00 on domain 1: 0.51111 elapsed seconds Timing for main: time 2000-01-25_00:00:00 on domain 1: 0.54507 elapsed seconds Timing for Writing wrfout_d01_2000-01-25_00:00:00 for domain 1: 0.03793 elapsed seconds d01 2000-01-25_00:00:00 Input data is acceptable to use: wrfbdy_d01 2 input_wrf: wrf_get_next_time current_date: 2000-01-25_00:00:00 Status = -4 d01 2000-01-25_00:00:00 ---- ERROR: Ran out of valid boundary conditions in file wrfbdy_d01 At line 777 of file module_date_time.f90 Fortran runtime error: Bad value during integer read Error termination. Backtrace: #0 0x10e67c36c #1 0x10e67d075 #2 0x10e67d7e9 ``` 4. With this fix, if we try to extend the module simulation beyond the valid lateral boundary times ``` Timing for main: time 2000-01-24_23:54:00 on domain 1: 0.60755 elapsed seconds Timing for main: time 2000-01-24_23:57:00 on domain 1: 0.57641 elapsed seconds Timing for main: time 2000-01-25_00:00:00 on domain 1: 0.60817 elapsed seconds Timing for Writing wrfout_d01_2000-01-25_00:00:00 for domain 1: 0.04499 elapsed seconds d01 2000-01-25_00:00:00 Input data is acceptable to use: wrfbdy_d01 2 input_wrf: wrf_get_next_time current_date: 2000-01-25_00:00:00 Status = -4 -------------- FATAL CALLED --------------- FATAL CALLED FROM FILE: <stdin> LINE: 1134 ---- ERROR: Ran out of valid boundary conditions in file wrfbdy_d01 ------------------------------------------- ``` MMM Classroom regtest; em_real, nmm, em_chem; GNU only

Add tendencies output

TYPE: bug fix KEYWORDS: unary operator, Noahmp SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Found more occurrences of `a* -b` in Noahmp. A space is in between `*` and `-1`. OK even for Cray, but it is still non-standard. Solution: The same solution is applied: add parentheses: `a * (-b)`. ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#33 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. More code is fixed. 2. Jenkins tests are all passing.

SWiFT 20131108 perturbation methods intercomparison convective case

Feature/bathymetry

This reverts commit 82447aa. modified: compile modified: tools/gen_wrf_io.c

sync up develop branch

mkavulich added 2 commits September 9, 2016 10:34

Fixing some typos in WRFDA code

1d22441

Fixing more typos in WRFDA code

04d0151

Based on pull request comments, fixing persistent typo in several fil…

6aff1b7

…es (assmiilation -> assimilation). Found a few more typos along the way as well.

davegill reviewed Sep 9, 2016
View reviewed changes

mkavulich added 2 commits September 9, 2016 12:41

Another round of typo fixes from pull request comments, thanks Jamie

70230b5

Reverting changes based on pull request feedback

0f8c25c

mkavulich merged commit 5ce8bd5 into wrf-model:master Sep 9, 2016

davegill mentioned this pull request Sep 16, 2016

Hybrid vertical coordinate for ARW #5

Closed

davegill mentioned this pull request Apr 27, 2018

Update version_decl and top level README for Friendly #2 #473

Merged

liujake mentioned this pull request May 2, 2018

TL/AD code sync with WRF changes #474

Merged

barlage mentioned this pull request May 3, 2018

Bugfix: Address an issue related to initialization of Noah-MP groundwater #463

Merged

johnrobertlawson pushed a commit to johnrobertlawson/WRF that referenced this pull request Mar 31, 2019

Adding morphing params to TWOSTREAM call wrf-model#2

e666ce2

rmfonsecaweb mentioned this pull request Jun 4, 2019

Precipitating Convective Cloud (PCC): cloud-radiation feedbacks for BMJ Cumulus Scheme #921

Merged

hmorrison100 mentioned this pull request Jan 31, 2020

Update of P3 module #1068

Merged

davegill added a commit to smileMchen/WRF that referenced this pull request Feb 10, 2020

attempt at space reconciliation wrf-model#2

cf93d0f

dmey referenced this pull request in TEB-model/wrf-teb Mar 31, 2020

add more compiler runtime checks and enable by default (#2)

545a466

Tuanph1970 mentioned this pull request Aug 18, 2020

Could not open new netcdf file structure #1274

Open

cxyiyh mentioned this pull request Nov 1, 2020

When I run /chem/convert_emiss.exe,the error occurs. #1310

Open

cenlinhe mentioned this pull request Nov 4, 2020

WRF-urban updates for the next WRF release #1309

Closed

jordanschnell added a commit to jordanschnell/WRF that referenced this pull request Dec 29, 2020

FIle move wrf-model#2/2, module_ctrans_aqchem

1a4e5e5

dwongepa mentioned this pull request Mar 14, 2021

CMAQ-WRF coupling #1432

Closed

twjuliano pushed a commit to twjuliano/WRF that referenced this pull request Jun 15, 2021

Merge pull request wrf-model#2 from ewquon/feature/tendencies

be1f943

Add tendencies output

htan2013 mentioned this pull request Sep 6, 2021

Received signal SIGFPE(8) when initializing WRF4.3 with ERA5 and modis data #1549

Open

davegill added a commit to MicroTed/WRFV4 that referenced this pull request Sep 16, 2021

parnetcdf trigger wrf-model#2

4bb5d9c

jinjiuping mentioned this pull request Dec 27, 2021

Program received signal SIGABRT: Process abort signal. #1620

Closed

mefrediani mentioned this pull request Feb 10, 2022

MP38 Thompson 2-mom graupel/hail #1667

Closed

mefrediani mentioned this pull request Mar 1, 2022

PBL and LES using feedback =1 #1690

Open

twjuliano pushed a commit to twjuliano/WRF that referenced this pull request Jun 13, 2022

Merge pull request wrf-model#2 from jsauer-NCAR/master

8d06e07

SWiFT 20131108 perturbation methods intercomparison convective case

twjuliano pushed a commit to twjuliano/WRF that referenced this pull request Jun 13, 2022

Merge pull request wrf-model#2 from phawbeck/feature/bathymetry

9565e75

Feature/bathymetry

ahheo added a commit to ahheo/WRF that referenced this pull request Feb 18, 2024

changes suggested by islas wrf-model#2

82447aa

ahheo added a commit to ahheo/WRF that referenced this pull request Feb 19, 2024

Revert "changes suggested by islas wrf-model#2"

30eaaa4

This reverts commit 82447aa. modified: compile modified: tools/gen_wrf_io.c

smileMchen pushed a commit to smileMchen/WRF that referenced this pull request Jul 11, 2024

Merge pull request wrf-model#2 from wrf-model/develop

c8d86d3

sync up develop branch

maxibaka mentioned this pull request Jul 20, 2024

Segmentation fault when sf_urban_physics=2or3 #2083

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing typographic errors in the WRFDA code #2

Fixing typographic errors in the WRFDA code #2

mkavulich commented Sep 9, 2016

mgduda commented Sep 9, 2016

jamiebresch commented Sep 9, 2016 •

edited

Loading

mkavulich commented Sep 9, 2016

jamiebresch commented Sep 9, 2016

davegill Sep 9, 2016

mkavulich Sep 9, 2016

jamiebresch commented Sep 9, 2016

jamiebresch commented Sep 9, 2016

Fixing typographic errors in the WRFDA code #2

Fixing typographic errors in the WRFDA code #2

Conversation

mkavulich commented Sep 9, 2016

mgduda commented Sep 9, 2016

jamiebresch commented Sep 9, 2016 • edited Loading

mkavulich commented Sep 9, 2016

jamiebresch commented Sep 9, 2016

davegill Sep 9, 2016

Choose a reason for hiding this comment

mkavulich Sep 9, 2016

Choose a reason for hiding this comment

jamiebresch commented Sep 9, 2016

jamiebresch commented Sep 9, 2016

jamiebresch commented Sep 9, 2016 •

edited

Loading