-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for aerosol optics Mie extrapolation WRFchem #1592
Conversation
Synchronize the develop branch from official WRF GitHub
sync up develop branch
@cenlinhe - There is an error check above your lines that with hard coded values for the range. What do you think about adding a warning in your check and/or harmonizing it with the 1e-3 - 10 range check? |
@jordanschnell That is actually the inconsistent place in the current chemistry. The 1e-3 - 10 range check does not prevent the extrapolation bug, because the minimum bound of the lookup table is close to 1.0. If the refractive index is much smaller than 1.0, the unstable extrapolation will occur, leading to unrealistic aerosol optics. |
@cenlinhe I see, I think putting a debug print statement for when they are reset to the bounds would be nice but not necessary |
@jordanschnell Thanks for the suggestion. I have added a debug printout statement to warn that the values are reset to bounds. Please see the updated commit and file. |
@jordanschnell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding the warning/print.
TYPE: bug fix KEYWORDS: aerosol optics, Mie calculation, interpolation, extrapolation SOURCE: Cenlin He and Rajesh Kumar (NCAR) DESCRIPTION OF CHANGES: Problem: When the aerosol refractive indices are outside the lookup table ranges (which are very rare occasions), the extrapolation in the parameterized Mie calculation ('mieaer' subroutine) will create unrealistic values for the extrapolated aerosol optical parameters. These unphysical fluctuations cause unrealistically high AOD values (10^10 and greater) and the model crashes. Solution: Force the out-of-range aerosol refractive index to be the min or max boundary values of the lookup table. LIST OF MODIFIED FILES: chem/module_optical_averaging.F TESTS CONDUCTED: 1. This solution fixes the issue and has been tested in NCAR Cheyenne HPC by Cenlin He (NCAR). 2. Jenkins testing is all PASS. RELEASE NOTE: Minor bugfix for aerosol optics Mie extrapolation cases in chemistry. When the aerosol refractive indices are outside the lookup table ranges, the extrapolation in the parameterized Mie calculation will create unrealistic values for the extrapolated aerosol optical parameters. These unphysical fluctuations cause unrealistically high AOD values and the model crashes. The solution is to force the out-of-range aerosol refractive index to be the minimum or maximum boundary values of the lookup table.
TYPE: bug fix
KEYWORDS: aerosol optics, Mie calculation, interpolation, extrapolation
SOURCE: Cenlin He and Rajesh Kumar (NCAR)
DESCRIPTION OF CHANGES:
Problem:
When the aerosol refractive indices are outside the lookup table ranges (which are very rare occasions), the
extrapolation in the parameterized Mie calculation ('mieaer' subroutine) will create unrealistic values for the
extrapolated aerosol optical parameters. These unphysical fluctuations cause unrealistically high AOD
values (10^10 and greater) and the model crashes.
Solution:
Force the out-of-range aerosol refractive index to be the min or max boundary values of the lookup table.
LIST OF MODIFIED FILES:
chem/module_optical_averaging.F
TESTS CONDUCTED:
RELEASE NOTE: Minor bugfix for aerosol optics Mie extrapolation cases in chemistry. When the aerosol refractive indices are outside the lookup table ranges, the extrapolation in the parameterized Mie calculation will create unrealistic values for the extrapolated aerosol optical parameters. These unphysical fluctuations cause unrealistically high AOD values and the model crashes. The solution is to force the out-of-range aerosol refractive index to be the minimum or maximum boundary values of the lookup table.