Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculation for accumulated physics tendencies for theta, qv, u and v #1583

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Add calculation for accumulated physics tendencies for theta, qv, u and v #1583

merged 4 commits into from
Dec 16, 2021

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Nov 15, 2021

TYPE: enhancement

KEYWORDS: accumulated physics tendencies, diagnostics only

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
WRF model can output physics tendencies at any output times, but they are instantaneous values.

Solution:
Add calculation to accumulate physics tendencies in any history output window for theta, qv, u and v fields. In all, 16
new arrays are added for cumulus, microphysics, shallow cumulus, PBL and radiation. The calculation can be turned
on by namelist switch acc_phy_tend = 1 in &physics.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/module_diagnostics_driver.F
M phys/module_diag_misc.F

TESTS CONDUCTED:

  1. Tests are conducted, and accumulated tendency output is checked.
  2. Jenkins tests are all passing.

RELEASE NOTE: Sixteen accumulated physics tendencies fields for potential temperature, water vapor mixing ratio, u and v components of the wind are added, and it can be turned on by namelist option acc_phy_tend = 1 in &physics.

@weiwangncar
Copy link
Collaborator Author

Jenkins tests are all passing:
Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 19 17
Number of Builds : 48 45
Number of Simulations : 160 155 0
Number of Comparisons : 101 100 0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted and replaced

@davegill
Copy link
Contributor

@weiwangncar
A couple of review requests to consider in this accumulated tendency PR:

  1. a debug level for the print that says "resetting back to zero"
  2. make the option MAX_DOMAIN, maybe only need the tendencies on a particular domain

Make namelist control domain-dependent.
@weiwangncar
Copy link
Collaborator Author

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           58
Number of Simulations  : 159           155        0
Number of Comparisons  : 96           93        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@davegill davegill self-requested a review December 16, 2021 02:41
@davegill davegill merged commit 22662e5 into wrf-model:develop Dec 16, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
…nd v (wrf-model#1583)

TYPE: enhancement

KEYWORDS: accumulated physics tendencies, diagnostics only

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
WRF model can output physics tendencies at any output times, but they are instantaneous values.

Solution:
Add calculation to accumulate physics tendencies in any history output window for theta, qv, u and v fields. In all, 16 
new arrays are added for cumulus, microphysics, shallow cumulus, PBL and radiation. The calculation can be turned 
on by namelist switch acc_phy_tend = 1 in &physics.

LIST OF MODIFIED FILES: 
M       Registry/Registry.EM_COMMON
M       phys/module_diagnostics_driver.F
M       phys/module_diag_misc.F

TESTS CONDUCTED: 
1. Tests are conducted, and accumulated tendency output is checked.
2. Jenkins tests are all passing.

RELEASE NOTE: Sixteen accumulated physics tendencies fields for potential temperature, water vapor mixing ratio, u and v components of the wind are added, and it can be turned on by namelist option acc_phy_tend = 1 in &physics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants