Revert w_crit_cfl back to 1.0 (from temporary 1.2)

[davegill]

TYPE: bug fix

KEYWORDS: IEVA, cfl

SOURCE: internal

DESCRIPTION OF CHANGES:
This is a clean-up PR to 4412521 #1373 "Implicit Explicit Vertical Advection (IEVA)". We are resetting the default critical value to activate the w_damping option to the previous setting.

Problem:
The new namelist option w_crit_cfl replaces w_beta, where w_beta used to be set in module_model_constants.F and had a value of 1.0. Before this PR, the default value of w_crit_cfl was set to 1.2 in the Registry. If one didn't use the new namelist option to manually reset the value of w_crit_cfl to 1., that meant that w_damping would behave
differently from previous releases.

Solution:

1. With consultation with the developer, the value for w_crit_cfl is now set to 1.0 in the Registry file. This gives similar and expected behavior for when w_damping kicks in.
2. Also, a bit of column aligning in the neighborhood of this change was done to make the Registry a bit more tidy. "Try and leave this world a little better than you found it.", Robert Stephenson Smyth Baden-Powell.

LIST OF MODIFIED FILES:
modified: Registry/Registry.EM_COMMON

TESTS CONDUCTED:

1. There are no problems to test, just resetting the critical value for activating w_damping (from 1.2 to 1.0).
2. Let us all hope that Jenkins tests are all PASS.

[davegill]

@weiwangncar @louiswicker
Here is a massive mod. I understand it will take a few days to review this proposed change.

[louiswicker]

going to have to pull an all-nighter on this one.

…

On May 10, 2021, at 10:52 AM, Dave Gill ***@***.***> wrote: @weiwangncar <https://github.com/weiwangncar> @louiswicker <https://github.com/louiswicker> Here is a massive mod. I understand it will take a few days to review this proposed change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADUKPSAS7GV3HEVKEQBA53TM76KZANCNFSM44RRBSZA>.

---------------------------------------------------------------------------- | Dr. Louis J. Wicker | NSSL/FRDD Rm 3336 | National Weather Center | 120 David L. Boren Boulevard, Norman, OK 73072 | | E-mail: ***@***.*** ***@***.***> | HTTP: www.nssl.noaa.gov/~lwicker <http://www.nssl.noaa.gov/~lwicker> | Phone: (405) 325-6340 | Fax: (405) 325-2316 | I "Yet all is not lost," Francis said. "Human beings, while | capable of the worst, are also capable of rising above | themselves, choosing again what is good, and making | a new start, despite their mental and social conditioning." | | Pope Francis ---------------------------------------------------------------------------- | | "The contents of this message are mine personally and | do not reflect any position of the Government or NOAA." | ----------------------------------------------------------------------------

[davegill]

@weiwangncar
Would you please review this cfl change from 1.2 -> 1.0

[davegill]

jenkins

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: e8a7578d60431a2eb046aa9ba6d4b0b2cf3cd4dc, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1510. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None