Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASCII chars outside of 32-127 range #1446

Merged
merged 5 commits into from
Mar 28, 2021

Conversation

davegill
Copy link
Contributor

TYPE: text only

KEYWORDS: ASCII

SOURCE: internal

DESCRIPTION OF CHANGES:
Remove instances of non Fortran character set entries in the WRF source. All of these changes are comments.

  1. The \textemdash becomes "-"
  2. The non-American keyboard letters become a, e, i, o, u without the dots or accents
  3. The superscript 2 is removed, and replaced by a regular 2: W/m2
  4. Extra DOS carriage returns are removed (likely when the files come from windows machines)
  5. The degree symbol was removed
  6. An extra handy vim command was added

LIST OF MODIFIED FILES:
modified: chem/chemics_init.F
modified: chem/module_mosaic_newnucb.F
modified: hydro/Routing/module_gw_gw2d.F
modified: phys/module_fr_fire_phys.F
modified: phys/module_gocart_coupling.F
modified: phys/module_mp_fast_sbm.F
modified: phys/module_mp_gsfcgce_4ice_nuwrf.F
modified: phys/module_mp_ntu.F
modified: phys/module_ra_eclipse.F
modified: phys/module_sf_bep_bem.F
modified: phys/module_sf_noahmplsm.F
modified: share/module_check_a_mundo.F
modified: tools/non_ascii_finder.F

TESTS CONDUCTED:

  1. Text only, no changes to compiled code
  2. Jenkins is all PASS

	modified:   chem/chemics_init.F
	modified:   chem/module_mosaic_newnucb.F
	modified:   hydro/Routing/module_gw_gw2d.F
	modified:   phys/module_fr_fire_phys.F
	modified:   phys/module_gocart_coupling.F
	modified:   phys/module_mp_fast_sbm.F
	modified:   phys/module_mp_gsfcgce_4ice_nuwrf.F
	modified:   phys/module_mp_ntu.F
	modified:   phys/module_ra_eclipse.F
	modified:   phys/module_sf_bep_bem.F
	modified:   phys/module_sf_noahmplsm.F
	modified:   share/module_check_a_mundo.F
modified:   non_ascii_finder.F
 Changes to be committed:
modified:   chem/chemics_init.F
modified:   chem/module_mosaic_newnucb.F
modified:   hydro/Routing/module_gw_gw2d.F
modified:   phys/module_fr_fire_phys.F
modified:   phys/module_gocart_coupling.F
modified:   phys/module_mp_fast_sbm.F
modified:   phys/module_mp_gsfcgce_4ice_nuwrf.F
modified:   phys/module_mp_ntu.F
modified:   phys/module_ra_eclipse.F
modified:   phys/module_sf_bep_bem.F
modified:   phys/module_sf_noahmplsm.F
modified:   share/module_check_a_mundo.F
modified:   tools/non_ascii_finder.F
@davegill davegill changed the title Develop+extended ascii Remove ASCII chars outside of 32-127 range Mar 28, 2021
@davegill
Copy link
Contributor Author

@weiwangncar
Wei,
Here is the PR with the check on the ASCII range. This includes the NTU init mods. These changes are all comments.

weiwangncar
weiwangncar previously approved these changes Mar 28, 2021
@davegill davegill merged commit 510483c into wrf-model:develop Mar 28, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: text only

KEYWORDS: ASCII

SOURCE: internal

DESCRIPTION OF CHANGES:
Remove instances of non Fortran character set entries in the WRF source. All of these changes are comments.
1. The \textemdash becomes "-"
2. The non-American keyboard letters become a, e, i, o, u without the dots or accents
3. The superscript 2 is removed, and replaced by a regular 2: W/m2
4. Extra DOS carriage returns are removed (likely when the files come from windows machines)
5. The degree symbol was removed
6. An extra handy vim command was added

LIST OF MODIFIED FILES:
	modified:   chem/chemics_init.F
	modified:   chem/module_mosaic_newnucb.F
	modified:   hydro/Routing/module_gw_gw2d.F
	modified:   phys/module_fr_fire_phys.F
	modified:   phys/module_gocart_coupling.F
	modified:   phys/module_mp_fast_sbm.F
	modified:   phys/module_mp_gsfcgce_4ice_nuwrf.F
	modified:   phys/module_mp_ntu.F
	modified:   phys/module_ra_eclipse.F
	modified:   phys/module_sf_bep_bem.F
	modified:   phys/module_sf_noahmplsm.F
	modified:   share/module_check_a_mundo.F
	modified:   tools/non_ascii_finder.F

TESTS CONDUCTED: 
1. Text only, no changes to compiled code
2. Jenkins is all PASS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants