-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ASCII chars outside of 32-127 range #1446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: chem/chemics_init.F modified: chem/module_mosaic_newnucb.F modified: hydro/Routing/module_gw_gw2d.F modified: phys/module_fr_fire_phys.F modified: phys/module_gocart_coupling.F modified: phys/module_mp_fast_sbm.F modified: phys/module_mp_gsfcgce_4ice_nuwrf.F modified: phys/module_mp_ntu.F modified: phys/module_ra_eclipse.F modified: phys/module_sf_bep_bem.F modified: phys/module_sf_noahmplsm.F modified: share/module_check_a_mundo.F
modified: non_ascii_finder.F
Changes to be committed: modified: chem/chemics_init.F modified: chem/module_mosaic_newnucb.F modified: hydro/Routing/module_gw_gw2d.F modified: phys/module_fr_fire_phys.F modified: phys/module_gocart_coupling.F modified: phys/module_mp_fast_sbm.F modified: phys/module_mp_gsfcgce_4ice_nuwrf.F modified: phys/module_mp_ntu.F modified: phys/module_ra_eclipse.F modified: phys/module_sf_bep_bem.F modified: phys/module_sf_noahmplsm.F modified: share/module_check_a_mundo.F modified: tools/non_ascii_finder.F
@weiwangncar |
weiwangncar
previously approved these changes
Mar 28, 2021
weiwangncar
approved these changes
Mar 28, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: text only KEYWORDS: ASCII SOURCE: internal DESCRIPTION OF CHANGES: Remove instances of non Fortran character set entries in the WRF source. All of these changes are comments. 1. The \textemdash becomes "-" 2. The non-American keyboard letters become a, e, i, o, u without the dots or accents 3. The superscript 2 is removed, and replaced by a regular 2: W/m2 4. Extra DOS carriage returns are removed (likely when the files come from windows machines) 5. The degree symbol was removed 6. An extra handy vim command was added LIST OF MODIFIED FILES: modified: chem/chemics_init.F modified: chem/module_mosaic_newnucb.F modified: hydro/Routing/module_gw_gw2d.F modified: phys/module_fr_fire_phys.F modified: phys/module_gocart_coupling.F modified: phys/module_mp_fast_sbm.F modified: phys/module_mp_gsfcgce_4ice_nuwrf.F modified: phys/module_mp_ntu.F modified: phys/module_ra_eclipse.F modified: phys/module_sf_bep_bem.F modified: phys/module_sf_noahmplsm.F modified: share/module_check_a_mundo.F modified: tools/non_ascii_finder.F TESTS CONDUCTED: 1. Text only, no changes to compiled code 2. Jenkins is all PASS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: ASCII
SOURCE: internal
DESCRIPTION OF CHANGES:
Remove instances of non Fortran character set entries in the WRF source. All of these changes are comments.
LIST OF MODIFIED FILES:
modified: chem/chemics_init.F
modified: chem/module_mosaic_newnucb.F
modified: hydro/Routing/module_gw_gw2d.F
modified: phys/module_fr_fire_phys.F
modified: phys/module_gocart_coupling.F
modified: phys/module_mp_fast_sbm.F
modified: phys/module_mp_gsfcgce_4ice_nuwrf.F
modified: phys/module_mp_ntu.F
modified: phys/module_ra_eclipse.F
modified: phys/module_sf_bep_bem.F
modified: phys/module_sf_noahmplsm.F
modified: share/module_check_a_mundo.F
modified: tools/non_ascii_finder.F
TESTS CONDUCTED: