Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary file from test/em_real #1424

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Remove temporary file from test/em_real #1424

merged 1 commit into from
Mar 3, 2021

Conversation

davegill
Copy link
Contributor

@davegill davegill commented Mar 2, 2021

TYPE: no impact

KEYWORDS: remove

SOURCE: internal

DESCRIPTION OF CHANGES:
There is a file in the test/em_real directory that does not belong in the repository: landFilenames.

The landFilenames has a storied history:

commit 7629cd09d63d3d6c60203100f886fcc75bffb26f
Author: John Michalakes <[email protected]>
Date:   Fri Feb 18 18:55:16 2005 +0000
    Temporary addition for hires topo input. Should remove later. JM
    git-svn-id: https://svn-wrf-model.cgd.ucar.edu/trunk@753 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d

John's advice was to "remove later". We waited 16 years, and now we are removing the file.

LIST OF MODIFIED FILES:
D test/em_real/landFilenames

TESTS CONDUCTED:

  1. Jenkins is OK.

@davegill davegill requested review from a team as code owners March 2, 2021 02:16
@davegill davegill changed the base branch from master to develop March 2, 2021 02:16
@davegill davegill mentioned this pull request Mar 2, 2021
Closed
@davegill
Copy link
Contributor Author

davegill commented Mar 2, 2021

jenkins

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 0d32083aa24b04472faa9b4b732858d25e198473, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1424. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

kkeene44
kkeene44 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@kkeene44 kkeene44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can be okay with this. :)

@davegill davegill merged commit 236c1de into wrf-model:develop Mar 3, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@davegill @vlakshmanan-scala
remove temporary landFilenames from test/em_real (wrf-model#1424)
e70218a 
TYPE: no impact

KEYWORDS: remove 

SOURCE: internal

DESCRIPTION OF CHANGES:
There is a file in the test/em_real directory that does not belong in the repository: landFilenames.

The `landFilenames` has a storied history:
```
commit 7629cd0
Author: John Michalakes <[email protected]>
Date:   Fri Feb 18 18:55:16 2005 +0000
    Temporary addition for hires topo input. Should remove later. JM
    git-svn-id: https://svn-wrf-model.cgd.ucar.edu/trunk@753 b0b5d27b-6f0f-0410-a2a3-cb1e977edc3d
```
John's advice was to "remove later". We waited 16 years, and now we are removing the file.


LIST OF MODIFIED FILES:
D    test/em_real/landFilenames

TESTS CONDUCTED: 
1. Jenkins is OK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiwangncar weiwangncar weiwangncar approved these changes

@kkeene44 kkeene44 kkeene44 approved these changes

Assignees
No one assigned
Labels
Comments Only Develop Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davegill @weiwangncar @kkeene44