bug fix: improper indexing in add aircraft emissions #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KEYWORDS: chemistry, emissions, aircraft, indexing SOURCE: Stacy Walters (formerly NCAR) DESCRIPTION OF CHANGES: Problem: An improper loop indexing that can cause addressing or floating point errors when aircraft emissions are turned used. Solution: Fix indexing (i - dimension) for the conversion term, from i to its:ite ISSUE: none LIST OF MODIFIED FILES: M chem/module_emissions_anthropogenics.F TESTS CONDUCTED: 1. Jenkins test -- RELEASE NOTE: This fixes an improper indexing in a conversion factor when using aircraft emissions
jordanschnell
changed the title
|
@ravanah @kayeekayee I can't review my own PR - can one of you approve and I can merge it? Thanks. |
|
@jordanschnell |
davegill
approved these changes
Dec 29, 2020
|
Sorry Jordan, I was a little bit late.
Thank you Dave.
WIsh you all have a happy new year.
Ka Yee
…On Tue, Dec 29, 2020 at 10:49 AM Dave Gill ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1327 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKQSJVJ2MQLZHHJQ5H7Q7DSXIJDVANCNFSM4TTTT5PA>
.
|
|
@kayeekayee - I guess not necessary, but can you approve? I will merge. Thanks. |
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
KEYWORDS: chemistry, emissions, aircraft, indexing SOURCE: Stacy Walters (formerly NCAR) DESCRIPTION OF CHANGES: Problem: An improper loop indexing that can cause addressing or floating point errors when aircraft emissions are used. Solution: Fix indexing (i - dimension) for the conversion term, from i to its:ite LIST OF MODIFIED FILES: M chem/module_emissions_anthropogenics.F TESTS CONDUCTED: 1. Jenkins test PASSED RELEASE NOTE: Improper indexing in a conversion factor when using aircraft emissions for WRF Chem previously caused addressing (seg fault) or floating point errors. This has been corrected by matching the indexing on the LHS with the RHS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEYWORDS: chemistry, emissions, aircraft, indexing
SOURCE: Stacy Walters (formerly NCAR)
DESCRIPTION OF CHANGES:
Problem:
An improper loop indexing that can cause addressing or floating point errors when aircraft emissions are
used.
Solution:
Fix indexing (i - dimension) for the conversion term, from i to its:ite
LIST OF MODIFIED FILES:
M chem/module_emissions_anthropogenics.F
TESTS CONDUCTED:
RELEASE NOTE: Improper indexing in a conversion factor when using aircraft emissions for WRF Chem previously caused addressing (seg fault) or floating point errors. This has been corrected by matching the indexing on the LHS with the RHS.