Enhancement for crop-specific parameters in Noah-MP-Crop

[CharlesZheZhang]

TYPE: Enhancement

KEYWORDS: Noah-MP-Crop, specific-crop, parameters, photosynthesis, stomata

SOURCE: Zhe Zhang (University of Saskatchewan)

DESCRIPTION OF CHANGES: The current release WRF-Crop option 1, (Liu Xing's model), uses generic-crop parameters in
stomata subroutine, to calculate photosynthesis and stomata resistance, regardless of crop type. Also some parameters in
the crop parameters in MPTABLE.TBL, the first and second columns for corn and soybean are not consistent with the values
used in Xing's paper. This pull request fixes the parameter values for these two columns in the crop parameter section in
MPTABLE.TBL, as well as adds specific-crop photosynthesis-stomata parameters in this section.

LIST OF MODIFIED FILES:
phys/module_sf_noahmplsm.F
phys/module_sf_noahmpdrv.F
run/MPTABLE.TBL

TESTS CONDUCTED:

1. Coupled WRF-Crop simulation is conducted on Cheyenne. The results seem reasonable in terms of crop LAI and biomass.
   Presented these results with the Noah-MP LSM group meeting with Dr. Fei Chen.
2. Jenkins testing is all PASS.

RELEASE NOTE: Incorporate specific-crop parameters for photosynthesis and stomata subroutine in Noah-MP-Crop. The current release WRF-Crop option 1, (Liu Xing's model), uses generic-crop parameters in stomata subroutine, to calculate photosynthesis and stomata resistance, regardless of crop type. Also some parameters in the crop parameters in MPTABLE.TBL, the first and second columns for corn and soybean are not consistent with the values used in Xing's paper. This update fixes the parameter values for these two columns in the crop parameter section in MPTABLE.TBL, as well as adds specific-crop photosynthesis-stomata parameters in this section.
Zhang, Z., Barlage, M., Chen, F., Li, Y., Helgason, W., Xu, X., et al. (2020). Joint modeling of crop and irrigation in the Central United States using the Noah‐MP land surface model. Journal of Advances in Modeling Earth Systems. https://doi.org/10.1029/2020MS002159

[davegill]

@CharlesZheZhang
Zhe,
We are scheduling a bug fix release next week. I would like to hold your mods until the subsequent bug fix release (probably 2-3 months from now).

[davegill]

@weiwangncar @dudhia
For NoahMP, who do we now contact?

[davegill]

@weiwangncar @dudhia
Folks,
Also, weigh in on whether this is a bug fix (wrong parameters) or an enhancement.

[weiwangncar]

I prefer to leave this after 4.2.1. It looks like both Fei and Mike B. are part of the paper, Fei can probably take an initial look. I will send Fei an email. @barlage Mike, if you ever have a minute, could you comment on this PR? Thanks!

[ncarchen]

We (zhe, Jimy, and I) discussed it yesterday. This mod is more for a bug fix than for enhancement, and would be good to be included in the imminent release.

[dudhia]

Yes, but I also mentioned it is probably too late for 4.2.1 but you can propose it for that branch. Later we will have a 4.2.2 branch for this.

…

On Wed, Jul 15, 2020 at 11:07 AM ncarchen ***@***.***> wrote: We (zhe, Jimy, and I) discussed it yesterday. This mod is more for a bug fix than for enhancement, and would be good to be included in the imminent release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77DS4GV4SFKQJEFV6CTR3XO3VANCNFSM4O2FPACA> .

[ncarchen]

Yes, but I also mentioned it is probably too late for 4.2.1 but you can propose it for that branch. Later we will have a 4.2.2 branch for this.
…
On Wed, Jul 15, 2020 at 11:07 AM ncarchen @.***> wrote: We (zhe, Jimy, and I) discussed it yesterday. This mod is more for a bug fix than for enhancement, and would be good to be included in the imminent release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1256 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77DS4GV4SFKQJEFV6CTR3XO3VANCNFSM4O2FPACA .

Sounds OK to me. A few users asked this question, so it will be good to address it promptly.

[dudhia]

Meanwhile you can point them to your fork if they need it soon.

…

On Wed, Jul 15, 2020 at 11:20 AM ncarchen ***@***.***> wrote: Yes, but I also mentioned it is probably too late for 4.2.1 but you can propose it for that branch. Later we will have a 4.2.2 branch for this. … <#m_318161892651339071_> On Wed, Jul 15, 2020 at 11:07 AM ncarchen *@*.***> wrote: We (zhe, Jimy, and I) discussed it yesterday. This mod is more for a bug fix than for enhancement, and would be good to be included in the imminent release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1256 (comment) <#1256 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77DS4GV4SFKQJEFV6CTR3XO3VANCNFSM4O2FPACA . Sounds OK to me. A few users asked this question, so it will be good to address it promptly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77EGZJ23OUHGHFON4SLR3XQN3ANCNFSM4O2FPACA> .

[weiwangncar]

I'm ok with this PR.

[weiwangncar]

RELEASE NOTE

[CharlesZheZhang]

This is great. Thank you all!