fixed divide by zero in Shin-Hong PBL #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have forwarded this to Hailey Shin to look at,
Jimy
…On Mon, Jun 22, 2020 at 6:02 AM Matthias Göbel ***@***.***> wrote:
@MATZE77 <https://github.com/Matze77> requested review from
@wrf-model/physics on: #1219 <#1219>
fixed divide by zero in Shin-Hong PBL as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77HV5KVTUDXZMEBE2PTRX5B6FANCNFSM4OEQRMVA>
.
|
|
@dudhia |
|
From Hailey:
Can this get approved? |
|
I'm ok with the fix, if Hailey is. |
|
Yes.
…On Mon, Jul 6, 2020 at 8:57 PM weiwangncar ***@***.***> wrote:
I'm ok with the fix, if Hailey is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1219 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77DRTAMQF4CBX5XSJ3DR2KFHZANCNFSM4OEQRMVA>
.
|
weiwangncar
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: shin hong, divide by zero
SOURCE: Matthias Göbel (University of Innsbruck)
DESCRIPTION OF CHANGES: When using the Shin-Hong PBL with initially zero wind, divisions by zero can occur. This bug fix includes if-statements to avoid a crash of the model. All limit values that are used instead of the divisions by zero should be mathematically correct, except for the third change where I guessed the appropriate limit value.
LIST OF MODIFIED FILES: phys/module_bl_shinhong.F
RELEASE NOTE: fixed divide by zero in Shin-Hong PBL