Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum required WP version for plugins #103

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

irshadahmad21
Copy link
Contributor

@irshadahmad21 irshadahmad21 commented Feb 19, 2024

One of our users reported that the settings page is blank. Upon investigating, we found that the user was on WP 6.3.3 and we had mentioned the minimum requirement to be WP 6.2.

The reason for that blank page was that the settings JS script needs type="module" attribute which is set by WPSocio\WPUtils\ViteWPReactAssets.

WPSocio\WPUtils\ViteWPReactAssets uses wp_script_attributes filter (used by wp_get_script_tag) that WordPress falsely mentions to be available since WP 5.7, while in reality it is used only since WP 6.4 and it is not available till WP 6.3.3.

Thus, we are changing the minimum WP requirement to 6.4.

@irshadahmad21 irshadahmad21 self-assigned this Feb 19, 2024
Copy link

changeset-bot bot commented Feb 19, 2024

🦋 Changeset detected

Latest commit: 7522074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wptelegram Patch
wptelegram-comments Patch
wptelegram-login Patch
wptelegram-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@irshadahmad21 irshadahmad21 merged commit e12a25c into main Feb 19, 2024
6 checks passed
@irshadahmad21 irshadahmad21 deleted the update/min-wp-version branch February 19, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant