Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317 upload problem if file is not required #321

Merged
merged 2 commits into from
Jul 26, 2015

Conversation

romuloctba
Copy link
Contributor

Fix #317 upload problem if file is not required changing if($files) to if(count($files)

Fix #317 upload problem if file is not required changing if($files) to if(count($files)
@adammacias adammacias added this to the v2.8.0 milestone Jul 24, 2015
@adammacias
Copy link
Member

@romuloctba testei aqui e tá dando esse erro para mim... 😢 😢 😢

download

Alterei para:

if ( count( $files ) <= 1 ) { ... }

O erro saiu, mas o problema #317 continua...

if ( count($files) >= 1 ) {
@romuloctba
Copy link
Contributor Author

if ( count($files) >= 1 ) {
>= > e depois =

acho q agora vai hein rs

claudiosanches added a commit that referenced this pull request Jul 26, 2015
@claudiosanches claudiosanches merged commit e2b279a into master Jul 26, 2015
@claudiosanches claudiosanches deleted the fix-error-file-upload-not-required branch July 26, 2015 02:58
@romuloctba
Copy link
Contributor Author

@claudiosmweb era isso msm neh?

@AdsonCicilioti
Copy link
Contributor

Vou testar isso também, mas acredito que o Cláudio já o tenha feito. Ou não teria dado merge. he he XD

@romuloctba
Copy link
Contributor Author

^^ testa lá daí avisa aqui pra fecharmos a Issue, ou fecha vc mesmo se der td certo ^^

@romuloctba
Copy link
Contributor Author

(ps: por favor hehe)

@AdsonCicilioti
Copy link
Contributor

Desculpem queridos mas testei tanto em meu projeto quanto no ODIN puro com as devidas classes habilitadas, e o erro persiste. 😞

@romuloctba
Copy link
Contributor Author

Ah tá loco os cara sai mergeando tudo tb :P

kkkk vou rever, tem como vc postar o seu código?

2015-07-27 11:56 GMT-03:00 AdsonCicilioti [email protected]:

Desculpem queridos mas testei tanto em meu projeto quanto no ODIN puro com
as devidas classes habilitadas, e o erro persiste. [image: 😞]


Reply to this email directly or view it on GitHub
#321 (comment).

@AdsonCicilioti
Copy link
Contributor

Bom @romuloctba meu código é o mesmo deste PR e do exemplo do Wiki. Peguei o Odin atualizado, testei e nada.

@adammacias
Copy link
Member

@romuloctba dá um desconto, o @claudiosmweb perdeu um pouquinho das forças ao cortar o cabelo. ta-da 🎉 👯

@claudiosanches
Copy link
Member

xD
Como assim?
Vou testar isso direito depois e ver o que esta rolando.

@AdsonCicilioti
Copy link
Contributor

Olá pessoal! Alguém além do Claudio conseguiu testar se esta feature está ok?

adammacias added a commit that referenced this pull request Dec 3, 2016
Fix Contact form Bugs - labels and upload error ( #317, #397, #321 and #430 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants