This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Set WP_PLUGIN_DIR constant for tests #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents ugly failures caused by the symlink in the test suite.
|
🌟 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents ugly failures caused by the symlink in the test suite.
Since the test suite failures in #197 are caused by the symlink in the test setup and not anything in the plugin itself, defining the plugin dir correctly for tests seems like the best solution here. (If a user wants to register symlinks for their individual setup, they'll have to do something like this anyways, either by defining the whole plugin directory in a constant as this is doing, or by adding a filter to
plugins_urlorplugin_basename.)