Closes #7280: Preload Fonts - Enable feature automatically for specific cases

[Miraeld]

Description

Fixes #7280
It will enable automatically if the user is using the old Preload Fonts feature when upgrading to 3.19.

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

What was tested

Manual test of this feature.

How to test

When upgrading to 3.19, if the old preload fonts feature was enabled, it should enabled the new one by default.

Technical description

Documentation

This pull request includes changes to the inc/Engine/Admin/Settings/Subscriber.php file to improve the handling of font preloading during version upgrades. The most important changes include modifying the maybe_enable_auto_preload_fonts method to accept version parameters and adding a version comparison check.

Enhancements to version handling:

• inc/Engine/Admin/Settings/Subscriber.php: Modified the maybe_enable_auto_preload_fonts method to accept $new_version and $old_version parameters, and added a version comparison check to ensure the method only runs for versions older than 3.19.
• inc/Engine/Admin/Settings/Subscriber.php: Updated the get_subscribed_events method to include the version parameters in the maybe_enable_auto_preload_fonts callback.

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 01c2bc21	❌ 0.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (01c2bc2)	Report Missing	Report Missing	Report Missing
Head commit (b220bad)	39748	17425	43.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7319)	28	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[wordpressfan]

A few comments to make it works.
Thanks

[wordpressfan]

This part means that we will bailout when the old version is more than 3.19 and I don't think this is the case here.

I think we need to negate the condition.