Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change workflow dynamic lists' endpoints to the new endpoint #7168

Conversation

wordpressfan
Copy link
Contributor

Description

Fixes #7113

Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).

Detailed scenario

We changed the urls of dynamic lists in github workflow to use v2 urls.

Technical description

Documentation

Small change to use the new endpoints instead of old ones.

New dependencies

Depending on merging this issue: https://github.com/wp-media/rucss-backend/issues/149 to production

Risks

No

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

That's not a change in codebase, it's in the CI workflow.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan self-assigned this Dec 4, 2024
@wordpressfan wordpressfan marked this pull request as ready for review December 4, 2024 10:32
Copy link

codacy-production bot commented Dec 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82a2c24) 38228 16731 43.77%
Head commit (a06c804) 38228 (+0) 16731 (+0) 43.77% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7168) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jeawhanlee jeawhanlee linked an issue Dec 4, 2024 that may be closed by this pull request
@jeawhanlee jeawhanlee added the noQA label Dec 4, 2024
@wordpressfan wordpressfan merged commit fd47450 into feature/3.18 Dec 13, 2024
14 checks passed
@wordpressfan wordpressfan deleted the feature/7113-workflow-change-delayjs-exclusions-endpoint branch December 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dynamic lists deploy workflow with the new endpoint
2 participants