Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear critical images shouldn't be in admin bar while not having valid license #6561

Closed
Mai-Saad opened this issue Apr 16, 2024 · 0 comments · Fixed by #6611
Closed

Clear critical images shouldn't be in admin bar while not having valid license #6561

Mai-Saad opened this issue Apr 16, 2024 · 0 comments · Fixed by #6611
Assignees
@jeawhanlee
Labels
priority: low Issues that can wait severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.16

Comments

@Mai-Saad
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => feature/lcp-above-the-fold-optimization commit 1c4062a
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Clear critical images is displayed in admin bar while not validating license

To Reproduce
Steps to reproduce the behavior:

  1. Install WPR using CLI
  2. Don't add license data in wp-config
  3. Activate WPR and try to access settings then hover on admin bar

Expected behavior
Clear critical images is not displayed as same as for clear cache

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot from 2024-04-16 10-06-53

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
@Mai-Saad Mai-Saad added type: bug Indicates an unexpected problem or unintended behavior priority: low Issues that can wait severity: minor Defect that does not affect functionality lcp labels Apr 16, 2024
@Mai-Saad Mai-Saad changed the title Clear critical images shouldn't be in admin var while not having valid license Clear critical images shouldn't be in admin bar while not having valid license Apr 16, 2024
@jeawhanlee jeawhanlee mentioned this issue May 3, 2024
Merged
19 tasks
@piotrbak piotrbak added this to the 3.16 milestone May 3, 2024
github-merge-queue bot pushed a commit that referenced this issue May 6, 2024
@jeawhanlee
Closes #6561: Clear critical images should not be in admin bar with i…
f6e7662 
…nvalid license (#6611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeawhanlee jeawhanlee

Labels
priority: low Issues that can wait severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.16
3 participants
@piotrbak @jeawhanlee @Mai-Saad