Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Node Fixes #94

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Public Node Fixes #94

merged 6 commits into from
Jun 20, 2022

Conversation

mukul-mehta
Copy link
Contributor

  • Use the response directly (data instead of data.nodeUID) in makePublic call
  • Fix toast when updating parentNote of connected portals. It used to show the old node name in the toast

sahil-shubham
sahil-shubham approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@sahil-shubham sahil-shubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things fixed and styling updated, public node shouldn't break for another day or two now. Merging.

@sahil-shubham sahil-shubham merged commit 3cd08b7 into main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil-shubham sahil-shubham sahil-shubham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mukul-mehta @sahil-shubham