Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminders v1 #93

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Reminders v1 #93

merged 7 commits into from
Jun 22, 2022

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Jun 20, 2022

In this PR

  • Added reminders view on webapp
  • Native browser notifications implemented
  • fixed double placeholder bug
  • Removed devtools middleware and updated and fixed zustand store sharing across frames

Limitations

  • Currently only 1 reminder is shown at a time, unlike mex where a bunch of notifications are also shown if missed
  • One tab needs to be open in the user's browser for the whole reminder flow, this involves, post creating a reminder on webapp, Chotu syncs the webapp store with the extension reminder store
    • Then the ReminderArmer component arms (sets timeout) for the reminder when it is near
    • Then it sends a message to the background worker when needed
    • Background worker has listeners for buttons presses, which are analyzed by the useRaju hook, which also sends a message through chotu to webapp to update reminder status
  • OnClick on notification has been commented out because the notification buttons clicks are also considered as notification clicks by chrome, this may be mac specific because mac groups the buttons in a list
  • During the onboarding process (i.e. whenever we get to it), the user should be informed that the reminders require the user to turn on system notifications for chrome (which is not something that needs to be done for mex)

@sahil-shubham sahil-shubham force-pushed the reminder-stuff branch 2 times, most recently from c3596c8 to 2c7aed5 Compare June 22, 2022 11:51
… initiliazed on new frame addition and different channels for different variables;

Signed-off-by: Sahil Shubham <[email protected]>
@mukul-mehta mukul-mehta marked this pull request as ready for review June 22, 2022 22:18
@mukul-mehta mukul-mehta self-requested a review June 22, 2022 22:18
@mukul-mehta mukul-mehta changed the title Reminder stuff Reminders v1 Jun 22, 2022
@sahil-shubham sahil-shubham merged commit 4c47413 into main Jun 22, 2022
manavagr1108 pushed a commit that referenced this pull request Jun 23, 2022
#93

* added reminders view;

Signed-off-by: Sahil Shubham <[email protected]>

* added useReminders to extension; move reminder store constructor to core lib;

Signed-off-by: Sahil Shubham <[email protected]>

* POC tested; native browser notifications implemented;

Signed-off-by: Sahil Shubham <[email protected]>

* fixed double placeholder post dnd addition;

Signed-off-by: Sahil Shubham <[email protected]>

* deps: added date-fns in extension;

Signed-off-by: Sahil Shubham <[email protected]>

* removed devtools from stores and updated options for sharing zustand; initiliazed on new frame addition and different channels for different variables;

Signed-off-by: Sahil Shubham <[email protected]>

* added support for buttons in notifications;

Signed-off-by: Sahil Shubham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants