-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reminders v1 #93
Merged
Merged
Reminders v1 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3596c8
to
2c7aed5
Compare
Signed-off-by: Sahil Shubham <[email protected]>
…ore lib; Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
2c7aed5
to
fc093e4
Compare
Signed-off-by: Sahil Shubham <[email protected]>
… initiliazed on new frame addition and different channels for different variables; Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
mukul-mehta
approved these changes
Jun 22, 2022
manavagr1108
pushed a commit
that referenced
this pull request
Jun 23, 2022
#93 * added reminders view; Signed-off-by: Sahil Shubham <[email protected]> * added useReminders to extension; move reminder store constructor to core lib; Signed-off-by: Sahil Shubham <[email protected]> * POC tested; native browser notifications implemented; Signed-off-by: Sahil Shubham <[email protected]> * fixed double placeholder post dnd addition; Signed-off-by: Sahil Shubham <[email protected]> * deps: added date-fns in extension; Signed-off-by: Sahil Shubham <[email protected]> * removed devtools from stores and updated options for sharing zustand; initiliazed on new frame addition and different channels for different variables; Signed-off-by: Sahil Shubham <[email protected]> * added support for buttons in notifications; Signed-off-by: Sahil Shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Limitations
ReminderArmer
component arms (sets timeout) for the reminder when it is nearuseRaju
hook, which also sends a message through chotu to webapp to update reminder status