Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Local ILinks Fixes + Block Modal #87

Merged

Conversation

mukul-mehta
Copy link
Contributor

  • Because we used the addILink function along with mex-backend, we ended up with duplicate copies of specific ILink elements. Now we do not use the addILink function and use the addNodeOrNodes function within the useNewNodes hook call. This causes no duplicates and updates the local data store and hierarchy on mex-backend
  • Add Block Modal to move/send/delete blocks to different nodes. This is till work in progress but will be finished in another PR

@linear
Copy link

linear bot commented Jun 16, 2022

WD-1357 [TASK] Block Modal and Create ILink Fixes

Since mex-backend now returns the ILinks, we don't need to create them locally. This was causing an issue of the same ILink being created twice, leading to a white screen.

Now we have a new hook useNewNodes that is used to create new nodes instead of locally creating an ilink with useDataStore

Add Block Modal that allows creating a new node or task from a block

Created by Mex

@sahil-shubham sahil-shubham force-pushed the mukul-wd-1357-task-block-modal-and-create-ilink-fixes branch from 1ee5b70 to c5521e4 Compare June 16, 2022 21:43
Signed-off-by: Sahil Shubham <[email protected]>
@sahil-shubham sahil-shubham merged commit 3b0be9e into main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants