Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better preview and saving on sputlit #85

Merged
merged 3 commits into from
Jun 15, 2022
Merged

better preview and saving on sputlit #85

merged 3 commits into from
Jun 15, 2022

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Jun 14, 2022 •
edited
Loading

In this PR

  • no more mouse based preview change, unless explicitly clicked on back icon
  • better saving on leaving normal mode and only closing on explicit cmd + s save
  • better node id generation for making multiple nodes in single session

Signed-off-by: Sahil Shubham [email protected]

@linear
Copy link

linear bot commented Jun 14, 2022 •
edited by sahil-shubham
Loading

WD-1341 [TASK] Fix sputlit preview

Description

  • If preview false, escape should make it true. Two escape should be needed to exit sputlit
    • Don't change sputlit preview on mouse move, results in user unable to use the webem in sputlit editor

Adding animation in this PR as well.

Purpose

What is the purpose of this task?

Additional Context

Any additional information that needs to be added

@sahil-shubham sahil-shubham marked this pull request as ready for review June 15, 2022 01:44
@sahil-shubham sahil-shubham merged commit fd2c495 into main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sahil-shubham