Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sahil shubham wd 1351 bug purge stores properly on logout #84

Merged

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Jun 14, 2022

In this PR

  • Fixed shortener action copy to clipboard
  • Updated dibba to look for links in Links heirarchy
  • Fix store purge on logout

@linear
Copy link

linear bot commented Jun 14, 2022

WD-1351 [BUG] Purge stores properly on logout

Describe the bug

Currently we just clear stores post logout, but because of moving away from webapp to the login screen without a page reload the 'cleared' stores are in the memory. Which results in them being the same on later creation. Happens with api-store which results in note not being fetched from backend post logging out and logging in.

Should create a local persist instance, which would give a purge function. Using that should be good, can also looking into PersistGateway to see if adding a loader before stores have been hydrated is a good idea or not. Had to add a loader for the same to fix WD-1342

Expected Behaviour

Explain what was supposed to happen

Screenshots

If applicable

Additional Context

Any additional things that might help gain context of the bug

Signed-off-by: Sahil Shubham <[email protected]>
@sahil-shubham sahil-shubham marked this pull request as ready for review June 14, 2022 14:56
@sahil-shubham sahil-shubham merged commit 190ccbd into main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant