Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding preview and redirect to extension iLink component #83

Merged

Conversation

sahil-shubham
Copy link
Member

@sahil-shubham sahil-shubham commented Jun 13, 2022

TODO

  • Added EditorPreview.tsx inside extension
  • Added preview on click in extension's ilink component
  • Fix webapp switch issue so that it takes node id from the url (EDIT: wasn't a switch issue, had to add a loadNode call if the node id of the current editor node and one from the url doesn't match but because of the store hydration taking considerable time, loadNode wasn't working. Added a 3 second loader instead)

Signed-off-by: Sahil Shubham [email protected]

@linear
Copy link

linear bot commented Jun 13, 2022

WD-1342 [TASK] Extension ILink component

Description

  • Add preview on click
  • Navigate to webapp on double click
  • Webapp switch issue

Purpose

What is the purpose of this task?

Additional Context

Any additional information that needs to be added

@sahil-shubham sahil-shubham marked this pull request as ready for review June 13, 2022 11:14
@mukul-mehta mukul-mehta merged commit 10dd59c into main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants