Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut Page and Floating Button #71

Merged

Conversation

mukul-mehta
Copy link
Contributor

  • Use the shortcutHandler hook to allow changing shortcuts
  • Update shortcuts used to use this hook instead of the callback inside of tinykeys directly
  • Add a shortcuts page and allow users to modify shortcuts
  • Add Floating Button for help on bottom right
  • Add About section to the settings page

@linear
Copy link

linear bot commented Jun 1, 2022

WD-1303 [FEATURE] Shortcut Page and Floating Help Button

Is your feature request related to a problem or an improvement? Please describe.

Add shortcut handler, shortcuts page and the floating button to webapp

@mukul-mehta mukul-mehta requested a review from sahil-shubham June 1, 2022 10:15
@mukul-mehta mukul-mehta force-pushed the mukul-wd-1303-feature-shortcut-page-and-floating-help branch from b7f677c to e8d7838 Compare June 1, 2022 15:48
Copy link
Member

@sahil-shubham sahil-shubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to persist shortcut store, currently gives this error on persisting from idb:

    Uncaught TypeError: get(...).modifiers.has is not a function

EDIT: I am stupid. Shortcuts are now persisted.

Signed-off-by: Sahil Shubham <[email protected]>
@sahil-shubham sahil-shubham merged commit 116f467 into main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants