Sahil shubham wd 1290 bug fix backlinks #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
WD-1290 [BUG] Fix backlinks
Describe the bugBacklinks are made from node path currently, change the new item handler for them to use nodeId. This should also fix the issue 'Node not found' when clicking on backlink, searching using backlink and sometimes creation of deplicated notes. Expected BehaviourExplain what was supposed to happen ScreenshotsIf applicable Additional ContextAny additional things that might help gain context of the bug |
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
Signed-off-by: Sahil Shubham <[email protected]>
manavagr1108
pushed a commit
that referenced
this pull request
Jun 20, 2022
#70 * copied over mex-editor; Signed-off-by: Sahil Shubham <[email protected]> * some refactoring in mex-editor; Signed-off-by: Sahil Shubham <[email protected]> * made mex-editor unpublishable; using it directly; Signed-off-by: Sahil Shubham <[email protected]> * uncommented block id generator plugin; Signed-off-by: Sahil Shubham <[email protected]> * updated non-exisiting imports from mex-editor; Signed-off-by: Sahil Shubham <[email protected]> * moved some stores inside mex-editor; Signed-off-by: Sahil Shubham <[email protected]> * fixed backlink preview and combobox on select; Signed-off-by: Sahil Shubham <[email protected]> * storage adapter check; Signed-off-by: Sahil Shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR